Open
Conversation
Fixed a bunch of typing problems with keyring. Unit tests now all pass. Fixed broken types and added typing to libraries. Upgraded vulnerable dependencies.
tiny-secp256k1 might be faster but it is NOT compatible with BROWSERS. This package is breaking inside the browser, aka on the Unisat extension because of this.
This reverts commit 3552541.
This reverts commit fc7b6dc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed a bunch of typing problems with keyring:
This contain breaking changes related to single keyring. Wallet must be upgraded as well. This version use a somewhat managable class abstraction to add more potential keyring. A PR will be made on the wallet including these changes.
Please note that the version that Unisat is using for encrypt/decrypt is deprecated and unmaitenained with potential security vulnerabilities. I recommend upgrading to https://github.com/MetaMask/browser-passworder which will be included in my PR.