feat: Enable P2TR key-path signing by tweaking signer when tapMerkleRoot is present#28
Open
SmarakNayak wants to merge 1 commit intounisat-wallet:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wrote a PR to enable P2TR key-path signing. This means users can spend P2TR scripts without revealing the script. The wallet signs with the private key corresponding to the address as opposed to the private key required by the script.
The code checks to see if tapMerkleRoot is present and tweaks the signer by the merkle root as necessary.
It works for both the tweaked and untweaked signer.
This should bring unisat to signing feature parity with xverse which currently supports key-path signing.
Please let me know if you have any questions!