fix: update bitcore-lib to v10.8.10 to resolve verifyMessageOfECDSA error#29
Open
originalix wants to merge 1 commit intounisat-wallet:masterfrom
Open
fix: update bitcore-lib to v10.8.10 to resolve verifyMessageOfECDSA error#29originalix wants to merge 1 commit intounisat-wallet:masterfrom
originalix wants to merge 1 commit intounisat-wallet:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue described in #26, where users encounter the following error:
Root Cause
The issue occurs because bitcore-lib was not version-locked, resulting in users inadvertently installing newer versions of bitcore-lib which introduced breaking changes. Specifically, in recent versions, ECDSA is no longer a constructor function.
Solution
The PR includes the following fixes:
Locked bitcore-lib to its latest stable version to prevent breaking changes in the future.
Adapted the codebase to accommodate the updated API.
Verified all unit tests pass successfully with the new changes.
Test
All unit tests are confirmed to be passing after these modifications.