Slack/Discord webhook support #72
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisPenner
force-pushed
the
cp/slack-webhooks
branch
from
8570fbf to
2fa2cf5
Compare
ChrisPenner
force-pushed
the
cp/slack-webhooks
branch
from
6d15000 to
c3caa83
Compare
ChrisPenner
force-pushed
the
cp/slack-webhooks
branch
from
694e47c to
8a6ba42
Compare
ChrisPenner
force-pushed
the
cp/slack-webhooks
branch
from
6f158f7 to
5bbcb17
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
We know we want Slack/Discord webhook support as a delivery mechanism for notifications. I knew I'd have to build out the translation layer for our own hooks anyways so I figured why not build it directly into Share to make it easier for everyone.
The end result is that you can just paste your Slack/Discord webhook URL in directly and Share will do the right thing and format a nice message for the webhook.
Implementation notes
Interesting/controversial decisions
Q: Should we be auto-intercepting these?
A: Yes, if the user were to paste one of these webhook handlers without special handling it would always fail since the default Share webhook payload isn't compatible with these webhook handlers, so we loose nothing by doing this automatically and gain a nice pain-free experience for the end-user. If they want to construct their own webhooks they can still easily do that with a Unison Cloud Service or wherever, which will have a URL that's not intercepted by the slack/discord webhook detector.
Test coverage
None at the moment, this is pretty tough to make tests for; I may re-visit the webhook payload test capturing server at some point, but it was quite unreliable last time I tried.
We'll be dogfooding these in Slack/Discord, so should notice if they drop out 🤞🏼