Skip to content

Some basic fixups for search #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 21, 2025
Merged

Some basic fixups for search #76

merged 5 commits into from
May 21, 2025

Conversation

ChrisPenner
Copy link
Contributor

Overview

Paul was getting some weird search results within the project:

image

This PR improves matching based on the final search segment a bit. It's still not as good as the main term search, ideally we'll switch over project search to use that mechanism but that's a more time intensive ordeal, so this is just a short-term patch for now.

Implementation notes

  • Fix a bug in the infix-pattern matcher so the LIKE queries work as expected
  • use the entire last segment of a dot-separated search when doing exact matching on last segment
  • Return the name that matched in the results rather than the 'best name'

Test coverage

Transcripts and local testing.

@ChrisPenner ChrisPenner enabled auto-merge May 21, 2025 18:47
@ChrisPenner ChrisPenner disabled auto-merge May 21, 2025 18:48
@ChrisPenner ChrisPenner merged commit 715e003 into main May 21, 2025
4 checks passed
@ChrisPenner ChrisPenner deleted the cp/find-fixups branch May 21, 2025 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant