Skip to content

Migrate to using prev and next cursor explicitly #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 3, 2025
Merged

Conversation

hojberg
Copy link
Contributor

@hojberg hojberg commented May 27, 2025

The API (with unisoncomputing/share-api#79) now supports a previous and a next cursor. Update the API integration to match.

@hojberg hojberg requested a review from ChrisPenner May 27, 2025 18:40
Copy link

netlify bot commented May 27, 2025

Deploy Preview for unison-share-ui ready!

Name Link
🔨 Latest commit dada6a6
🔍 Latest deploy log https://app.netlify.com/projects/unison-share-ui/deploys/683f3d0ba0e3260008392702
😎 Deploy Preview https://deploy-preview-82.staging.share.unison-lang.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 56 (🔴 down 10 from production)
Accessibility: 93 (no change from production)
Best Practices: 100 (🟢 up 8 from production)
SEO: 75 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@hojberg hojberg force-pushed the prev-next-cursor branch from e19f7d2 to 916422d Compare May 27, 2025 18:43
@ChrisPenner
Copy link

I'm not seeing anything in here that pulls the prevCursor/nextCursor from the response; or is that not in this PR?

@hojberg
Copy link
Contributor Author

hojberg commented May 28, 2025

@ChrisPenner currently we don't actually use pagination on any other page than the new notification hub (which uses prevCursor and nextCursor here: #78).

The pagination added to the notification hub should be fairly easy to re-use in all these other places, but wanted to focus this PR on compatibility first (even if it isn't really in use).

The API (with unisoncomputing/share-api#79) now
supports a previous and a next cursor. Update the API integration to match.
@hojberg hojberg force-pushed the prev-next-cursor branch from 916422d to dada6a6 Compare June 3, 2025 18:20
@hojberg hojberg merged commit 7669b63 into main Jun 3, 2025
6 checks passed
@hojberg hojberg deleted the prev-next-cursor branch June 3, 2025 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants