fix full type definition not being shown for new type defs in diff.update #6101
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The
diff.updatecommand now shows the full structure of new types and abilities, not just their names.Before:
After:
This matches the behavior for updated types, which already showed their full structure with inline diffs.
Implementation approach and notes
Changed
renderNewTypesinOutputMessages.hsto useDeclPrinter.prettyDecl(full declaration rendering) instead ofDeclPrinter.prettyDeclOrBuiltinHeader(header only). This required threadingTypeReferenceIdthrough fromDiffUpdate.hsand updating theShowUpdateDifftype inOutput.hs.Test coverage
unison-src/transcripts/idempotent/diff-update.mdthat covers new structural types and abilitiesLoose ends
None.
Final checklist