properly handle hashes and numbered args in branch.diff arg parser #6142
+67
−204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@mitchellwrosen I want to merge this, but it needs coverage in a transcript (unless is there some nondeterminism that I'm overlooking?) |
Member
Author
|
@aryairani Added |
Contributor
|
@mitchellwrosen Sweet |
Contributor
|
@mitchellwrosen Wait, can you add coverage for the numbered args part too. Coverage for all the parts 🚀 |
Member
Author
|
@aryairani Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes #6141
This PR tweaks the
branch.diffarg parser to properly handle hashes and numbered args that expand to hashes.Test coverage
I tested this manually