Die all pending requests/queries when client terminates #37
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation Complete: Add dieAll methods to handle pending requests/queries on client termination
dieAllmethod toPendingRequestsclass to die all pending requests with a given errordieAllmethod toPendingQueriesclass to die all pending queries with a given errordieAllon both pending requests and queries before dying the app in SessionExpired casesdieAllon both pending requests and queries before dying the app in InvalidCapabilities casedieAllon both pending requests and queries before dying the app in ResponseEvicted casedieAllmethods in PendingRequestsSpec and PendingQueriesSpecforeachDiscardinstead offoreach().unit(addressed review comments)Summary
This PR implements the functionality requested in the issue where the RaftClient should die all pending requests and queries when it terminates due to SessionExpired, ResponseEvicted, or InvalidCapabilities.
Changes Made:
dieAll(error: Throwable): UIO[Unit]method that dies all pending request promises with the given error usingZIO.foreachDiscarddieAll(error: Throwable): UIO[Unit]method that dies all pending query promises with the given error usingZIO.foreachDiscarddieAllon both pending requests and queries before terminatingdieAllmethodsAll 36 tests pass successfully. The implementation ensures that when the client decides to die, all pending requests and queries are properly terminated with an appropriate error before the client shuts down.
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.