-
Notifications
You must be signed in to change notification settings - Fork 919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Catboost native multi-output with RMSE #2659
Catboost native multi-output with RMSE #2659
Conversation
…anc/darts into feat/native-multioutput-catboost
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2659 +/- ##
==========================================
- Coverage 94.16% 94.10% -0.07%
==========================================
Files 141 141
Lines 15601 15596 -5
==========================================
- Hits 14691 14676 -15
- Misses 910 920 +10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @jonasblanc, this looks great and is going into the right direction 🚀
I added a couple of suggestions. The major point would be that I think we should leave it to the user to decide whether to use native, or darts' multioutput regression.
…anc/darts into feat/native-multioutput-catboost
…anc/darts into feat/native-multioutput-catboost
…anc/darts into feat/native-multioutput-catboost
…anc/darts into feat/native-multioutput-catboost
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @jonasblanc for the PR, just minor changes but it looks very good to me!
…anc/darts into feat/native-multioutput-catboost
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beautiful 😍 Thanks a lot for this great PR, and it also looks much more clean now with the refactoring to sklearn >= 1.6.0 🚀
Made some last minor updates.
Checklist before merging this PR:
Fixes #1306
Summary
Refactor logic handling native support for multi-output.
RegressionModel._native_support_multioutput()
(and sub-classes) to return if the underlying model does support multi-output natively.MultiOutputRegressor
.sklearn
_get_tags
to__sklearn_tags__
as it will be required bysklearn
1.7. This leads to increasing both sklearn and XGBoost minimum supported version to 1.6 and 2.1.4 respectively. See sklearn release notes for more information about tags and XGBoost release notes forsklearn
1.6 compatibility.CatBoostModel
documentation by describing how to use native multioutput regression.Other Information