-
Notifications
You must be signed in to change notification settings - Fork 919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/test optional dep (onnx, ray, optuna) #2702
Conversation
…ghts from checkpoint
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2702 +/- ##
==========================================
+ Coverage 94.18% 94.22% +0.03%
==========================================
Files 141 142 +1
Lines 15598 15647 +49
==========================================
+ Hits 14691 14743 +52
+ Misses 907 904 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice PR, thanks a lot @madtoinou 🚀
Just had some minor suggestions
Checklist before merging this PR:
Fix #2651.
Summary
ray
,onnx
, andoptuna
optional dependenciesload_weights_from_checkpoint
, where theuse_X_covariates
were not properly updatedOther Information
from_dataframe
and performance benchmark #2661 could leverage the same logic.