Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/test optional dep (onnx, ray, optuna) #2702

Merged
merged 21 commits into from
Mar 8, 2025
Merged

Conversation

madtoinou
Copy link
Collaborator

@madtoinou madtoinou commented Feb 28, 2025

Checklist before merging this PR:

  • Mentioned all issues that this PR fixes or addresses.
  • Summarized the updates of this PR under Summary.
  • Added an entry under Unreleased in the Changelog.

Fix #2651.

Summary

  • Add a optional.txt file and update the github action workflow accordingly (cache update)
  • Added tests for the ray, onnx, and optuna optional dependencies
  • The tests of the optional dependencies are included in the coverage check of the "all" darts flavor.
  • Fix a bug in load_weights_from_checkpoint, where the use_X_covariates were not properly updated

Other Information

  • The tests for the optional dependencies were heavily inspired from the example contained in the User Guide, should make it easier to maintain the documentation
  • The tests for polars and other optional libraries providing dataframe-like data structure introduced with Narwhals implementation of from_dataframe and performance benchmark #2661 could leverage the same logic.

Copy link

codecov bot commented Feb 28, 2025

Codecov Report

Attention: Patch coverage is 81.63265% with 9 lines in your changes missing coverage. Please review.

Project coverage is 94.22%. Comparing base (19b17d2) to head (2a7c268).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...arts/models/forecasting/torch_forecasting_model.py 68.96% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2702      +/-   ##
==========================================
+ Coverage   94.18%   94.22%   +0.03%     
==========================================
  Files         141      142       +1     
  Lines       15598    15647      +49     
==========================================
+ Hits        14691    14743      +52     
+ Misses        907      904       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@dennisbader dennisbader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice PR, thanks a lot @madtoinou 🚀

Just had some minor suggestions

@dennisbader dennisbader merged commit f1850d6 into master Mar 8, 2025
9 checks passed
@dennisbader dennisbader deleted the feat/test_optional_dep branch March 8, 2025 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extend workflows to test optional dependencies (seperate check)
2 participants