Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/inverse transform for static covariate with single category across series #2710

Merged
merged 5 commits into from
Mar 7, 2025

Conversation

madtoinou
Copy link
Collaborator

@madtoinou madtoinou commented Mar 3, 2025

Checklist before merging this PR:

  • Mentioned all issues that this PR fixes or addresses.
  • Summarized the updates of this PR under Summary.
  • Added an entry under Unreleased in the Changelog.

Fixes #2705.

Summary

  • Each covariates is referred to by the combination of covariates name and category name, regardless of the number of categories (used to be for covariates with more than 1 category).

Other Information

This might be a breaking changes for some as it can change the number of covariates in the series but very unlikely in my opinion.

@madtoinou madtoinou requested a review from dennisbader as a code owner March 3, 2025 15:29
@madtoinou madtoinou changed the title Fix/static cov inv tf Fix/inverse transform for static covariate with single category across series Mar 3, 2025
Copy link

codecov bot commented Mar 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.10%. Comparing base (62dca8f) to head (7130b72).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2710      +/-   ##
==========================================
- Coverage   94.17%   94.10%   -0.08%     
==========================================
  Files         141      141              
  Lines       15596    15591       -5     
==========================================
- Hits        14688    14672      -16     
- Misses        908      919      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@dennisbader dennisbader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice fix, thanks a lot @madtoinou 🚀 🚀 🚀

@dennisbader dennisbader merged commit fabba0a into master Mar 7, 2025
9 checks passed
@dennisbader dennisbader deleted the fix/static_cov_inv_tf branch March 7, 2025 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants