Fixes bug when using historical forecast with discrete lags < -1 #2715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2715 +/- ##
==========================================
- Coverage 94.18% 94.10% -0.08%
==========================================
Files 141 141
Lines 15596 15598 +2
==========================================
- Hits 14689 14679 -10
- Misses 907 919 +12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I don't really know how/where to test the |
madtoinou
reviewed
Mar 5, 2025
There was a problem hiding this comment.
Nice PR, a few adjustments to make and it should be ready.
I don't really know how/where to test the overlap_end = True. A suggestion would be welcome!
You can create a new test, just for the _get_historical_forecast_boundaries method or eventually in one of the test for regression model optimized historical forecasts for example.
darts/tests/utils/historical_forecasts/test_historical_forecasts.py
Outdated
Show resolved
Hide resolved
madtoinou
reviewed
Mar 7, 2025
dennisbader
approved these changes
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist before merging this PR:
Fixes #2697.
Summary
When regression models had discrete lags < -1, the end of the window of the target series for the historical forecasts was not corrected correctly. I fixed this.
Other Information
Nan