-
Notifications
You must be signed in to change notification settings - Fork 919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes bug when using historical forecast with discrete lags < -1 #2715
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2715 +/- ##
==========================================
- Coverage 94.18% 94.10% -0.08%
==========================================
Files 141 141
Lines 15596 15598 +2
==========================================
- Hits 14689 14679 -10
- Misses 907 919 +12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
I don't really know how/where to test the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice PR, a few adjustments to make and it should be ready.
I don't really know how/where to test the overlap_end = True. A suggestion would be welcome!
You can create a new test, just for the _get_historical_forecast_boundaries
method or eventually in one of the test for regression model optimized historical forecasts for example.
darts/tests/utils/historical_forecasts/test_historical_forecasts.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks a lot for the fix @authierj 🚀
Checklist before merging this PR:
Fixes #2697.
Summary
When regression models had discrete lags < -1, the end of the window of the target series for the historical forecasts was not corrected correctly. I fixed this.
Other Information
Nan