-
Notifications
You must be signed in to change notification settings - Fork 919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adding support for getting estimator based on quantile #2716
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2716 +/- ##
==========================================
- Coverage 94.18% 94.10% -0.08%
==========================================
Files 141 141
Lines 15591 15596 +5
==========================================
- Hits 14684 14677 -7
- Misses 907 919 +12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks a lot @madtoinou
As discussed, let's let get_estimator
handle all the logic and remove get_multioutput_estimators
.
Then all good to be merged :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect 💯
Checklist before merging this PR:
Fixes #2596.
Summary
Other Information
get_multioutput_regressor
andget_estimator
is a bit ambiguous, we could maybe simplify it.quantiles=[...]
withlikelihood="poisson"
without raising an exception. We abuse this mechanism in the tests but it should probably not be possible in the first place...