Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/code maintenance after dependencies update #2722

Merged
merged 6 commits into from
Mar 8, 2025

Conversation

madtoinou
Copy link
Collaborator

@madtoinou madtoinou commented Mar 7, 2025

Checklist before merging this PR:

  • Mentioned all issues that this PR fixes or addresses.
  • Summarized the updates of this PR under Summary.
  • Added an entry under Unreleased in the Changelog.

Summary

  • replace the deprecated _validate_data call with validate_data
  • removed unnecessary logic around sklearn version
  • removed unnecessary logic around statsmodel version

Other Information

Could not solve a lot of the deprecation warnings as they were occurring in the dependencies (prophet, shap, lightgbm, ...) so this PR is smaller than I would have liked...

@madtoinou madtoinou requested a review from dennisbader as a code owner March 7, 2025 15:28
Copy link
Collaborator

@dennisbader dennisbader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks a lot @madtoinou 🚀

Copy link

codecov bot commented Mar 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.25%. Comparing base (f1850d6) to head (5f01eea).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2722      +/-   ##
==========================================
- Coverage   94.29%   94.25%   -0.05%     
==========================================
  Files         142      142              
  Lines       15647    15635      -12     
==========================================
- Hits        14755    14736      -19     
- Misses        892      899       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dennisbader dennisbader merged commit d24d1b5 into master Mar 8, 2025
9 checks passed
@dennisbader dennisbader deleted the fix/code_maintenance branch March 8, 2025 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants