-
-
Notifications
You must be signed in to change notification settings - Fork 34
Fix broken alias checks #129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅
|
| Descriptor | Linter | Files | Fixed | Errors | Warnings | Elapsed time |
|---|---|---|---|---|---|---|
| ✅ COPYPASTE | jscpd | yes | no | no | 1.51s | |
| ✅ REPOSITORY | devskim | yes | no | no | 1.58s | |
| ✅ REPOSITORY | dustilock | yes | no | no | 0.01s | |
| ✅ REPOSITORY | gitleaks | yes | no | no | 0.13s | |
| ✅ REPOSITORY | git_diff | yes | no | no | 0.01s | |
| ✅ REPOSITORY | grype | yes | no | no | 27.49s | |
| kics | yes | 2 | no | 1.55s | ||
| ✅ REPOSITORY | secretlint | yes | no | no | 1.28s | |
| ✅ REPOSITORY | syft | yes | no | no | 2.07s | |
| ✅ REPOSITORY | trivy | yes | no | no | 8.48s | |
| ✅ REPOSITORY | trivy-sbom | yes | no | no | 0.13s | |
| ✅ REPOSITORY | trufflehog | yes | no | no | 3.66s |
Detailed Issues
⚠️ REPOSITORY / kics - 2 errors
MLLLLLM MLLLLLLLLL LLLLLLL KLLLLLLLLLLLLLLLL LLLLLLLLLLLLLLLLLLLLLLL
MMMMMMM MMMMMMMMMML MMMMMMMK LMMMMMMMMMMMMMMMMMMMML KLMMMMMMMMMMMMMMMMMMMMMMMMM
MMMMMMM MMMMMMMMML MMMMMMMK LMMMMMMMMMMMMMMMMMMMMMML LMMMMMMMMMMMMMMMMMMMMMMMMMMM
MMMMMMM MMMMMMMMMML MMMMMMMK LMMMMMMMMMMMMMMMMMMMMMMMML LMMMMMMMMMMMMMMMMMMMMMMMMMMMM
MMMMMMM LMMMMMMMMML MMMMMMMK LMMMMMMMMMLLMLLLLLLLLLLLLLL LMMMMMMMLLLLLLLLLLLLLLLLLLLLM
MMMMMMM MMMMMMMMMLM MMMMMMMK LMMMMMMMM LMMMMMML
MMMMMMMLMMMMMMMML MMMMMMMK MMMMMMML LMMMMMMMMLLLLLLLLLLLLLMLL
MMMMMMMMMMMMMMMM MMMMMMMK MMMMMML LMMMMMMMMMMMMMMMMMMMMMMMMML
MMMMMMMMMMMMMMMMMM MMMMMMMK MMMMMMM LMMMMMMMMMMMMMMMMMMMMMMMML
MMMMMMM KLMMMMMMMMML MMMMMMMK LMMMMMMM MMMMMMMML
MMMMMMM LMMMMMMMMMM MMMMMMMK LMMMMMMMMLL MMMMMMML
MMMMMMM LMMMMMMMMMLL MMMMMMMK LMMMMMMMMMMMMMMMMMMMMMMMMML LLLLLLLLLLLLLLLLLLLLMMMMMMMMMM
MMMMMMM MMMMMMMMMMML MMMMMMMK MMMMMMMMMMMMMMMMMMMMMMMMML LMMMMMMMMMMMMMMMMMMMMMMMMMMMM
MMMMMMM LLMMMMMMMMML MMMMMMMK LLMMMMMMMMMMMMMMMMMMMMML LMMMMMMMMMMMMMMMMMMMMMMMMMML
MMMMMMM MMMMMMMMMML MMMMMMMK KLMMMMMMMMMMMMMMMMML LMMMMMMMMMMMMMMMMMMMMMMMLK
Scanning with Keeping Infrastructure as Code Secure v2.1.14
Unpinned Actions Full Length Commit SHA, Severity: LOW, Results: 2
Description: Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps mitigate the risk of a bad actor adding a backdoor to the action's repository, as they would need to generate a SHA-1 collision for a valid Git object payload. When selecting a SHA, you should verify it is from the action's repository and not a repository fork.
Platform: CICD
CWE: 829
Learn more about this vulnerability: https://docs.kics.io/latest/queries/cicd-queries/555ab8f9-2001-455e-a077-f2d0f41e2fb9
[1]: .github/workflows/mega-linter.yml:52
051: - name: Lint Code Base
052: uses: megalinter/megalinter@v9
053: env:
[2]: .github/workflows/awesomebot.yml:17
016: - uses: actions/checkout@v5
017: - uses: docker://dkhamsing/awesome_bot:latest
018: with:
Results Summary:
CRITICAL: 0
HIGH: 0
MEDIUM: 0
LOW: 2
INFO: 0
TOTAL: 2
See detailed reports in MegaLinter artifacts
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff
|
Hi, I am traveling and do not have my personal computer with me. O will test the new versions as soon as possible. |
This caused a new bug, [128](#128) This reverts commit 5257af4. Signed-off-by: Joe Block <[email protected]>
#125 was caused when I used `_fzf_has()` in fzf-settings.zsh because fzf-zsh-plugin.plugin.zsh was unsetting that alias after it finished to keep the user's environment clean of extra functions, and fzf-settings.zsh was getting loaded later. Changing to inline `$+commands[name]` then broke using `z` because it doesn't find aliases, causing [128](#128) So _this_ fix uses a separate `fzf_settings_has()` function inside fzf-settings.zsh, which should hopefully solve 125 and 128. Signed-off-by: Joe Block <[email protected]>
14da0ae to
8cbb1ba
Compare
|
@yusiwen, @GabrielNexT and @iliis, this should have fixed your issues. LMK if not. |
|
The error still happens here, but now I can run fzf using ctrl+R.
|
|
@GabrielNexT try running |
|
Thank you for investigating this! I still got the errors, but this was fixed after I deleted the old Ctrl-R still doesn't work however. This might be because |


Description
125 was caused when I used
_fzf_has()infzf-settings.zshbecausefzf-zsh-plugin.plugin.zshwas unsetting that alias after it finished to keep the user's environment clean of extra functions, andfzf-settings.zshwas getting loaded later.Changing to inline
$+commands[name]then broke usingzbecause it doesn't find aliases, causing 128So this fix uses a separate
fzf_settings_has()function insidefzf-settings.zsh, which should hopefully solve 125 and 128.@yusiwen, @GabrielNexT and @iliis, please check this branch out and see if it solves your issues
Checklist
fzf-zsh-plugin.zsh, I have created standalone scripts in bin so they can be used by non-ZSH users too.#!/usr/bin/env interpreterinstead of potentially platform-specific direct paths (#!/bin/shis an ok exception)License Acceptance