Fix/external type references #46
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add tryLookupNode function to safely check for node existence - Update getJsType to generate placeholder types for external structs/enums/interfaces - Update getConcreteListType to handle missing struct nodes - Update generateNestedImports to skip missing import nodes This allows TypeScript generation to complete for files that import types from other compilation units, fixing the 'Failed to look up node id' errors.
Add tryLookupNode function to safely handle missing external type references without throwing errors. Generate placeholder type names for external types that aren't available in the current compilation context.
Note that doing that could be dangerous as the compiler is pre 1.0 and the API might break at any time. That being said I guess it's ok to add this feature. Could you please add a test to the PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TypeScript code generator throws an error when it encounters references to external types that aren't available in the current compilation context. This happens when a Cap'n Proto schema imports types from other schemas that aren't being compiled in the same invocation.
When the compiler encounters an external type reference (struct, enum, or interface) that isn't in the current node context, it throws an error in lookupNode() with message: "missing node".
Expected Behavior
The compiler should gracefully handle external type references by generating placeholder type names, allowing the compilation to complete successfully.
Changes
Impact
This fix prevents compilation failures in projects with modular schema organization where not all referenced types are available during every compilation run.
Resolves #45