Skip to content

Conversation

PKief
Copy link
Contributor

@PKief PKief commented Sep 21, 2025

Enhances contributor attribution by adding a fallback mechanism that uses GitHub PR author information when email-to-username resolution fails.

Resolves #116

Changes

  • Added getPullRequestAuthorLogin() function in github.ts to fetch PR author details
  • Enhanced generateMarkDown() in markdown.ts with PR author fallback logic
  • Added helper function getAuthorPRNumber() to extract PR numbers from commit references

Benefits

  • Better contributor attribution in changelogs
  • Fallback mechanism for private email addresses
  • No breaking changes to existing functionality

Copy link

codecov bot commented Sep 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.03%. Comparing base (0914fd7) to head (23dc19e).
⚠️ Report is 81 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #294      +/-   ##
==========================================
- Coverage   69.10%   60.03%   -9.07%     
==========================================
  Files           9       12       +3     
  Lines         916     1046     +130     
  Branches       85      148      +63     
==========================================
- Hits          633      628       -5     
- Misses        283      416     +133     
- Partials        0        2       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@PKief PKief force-pushed the fix/enhance-contributor-tagging branch from c429a33 to 23dc19e Compare October 13, 2025 13:23
@PKief
Copy link
Contributor Author

PKief commented Oct 13, 2025

Hi @pi0, I've added some additional unit tests to increase the coverage. Unfortunately, I'm not exactly sure why the codecov check is still failing. It compares my changes with some commit made one year ago: 0914fd7 This commit is not even the latest one on the main branch.

Do you have any idea how I can get this PR in?

@pi0
Copy link
Member

pi0 commented Oct 13, 2025

It looks a very good PR dear @PKief. I'm little bit occupied to do final review/merge/releases.

Will do as soon as could.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GitHub username mentions for GitHub releases

2 participants