Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support RETURNING clause #139

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

feat: support RETURNING clause #139

wants to merge 6 commits into from

Conversation

ginnwork
Copy link

Resolves #138

@pi0
Copy link
Member

pi0 commented Dec 23, 2024

Can you please add a test? 🙏🏼

@pi0 pi0 changed the title Added support for RETURNING clause feat: support for RETURNING clause Dec 23, 2024
@pi0 pi0 changed the title feat: support for RETURNING clause feat: support RETURNING clause Dec 23, 2024
Copy link

codecov bot commented Dec 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@2e62a68). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #139   +/-   ##
=======================================
  Coverage        ?   46.22%           
=======================================
  Files           ?       19           
  Lines           ?      675           
  Branches        ?       67           
=======================================
  Hits            ?      312           
  Misses          ?      358           
  Partials        ?        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nick-w-nick
Copy link
Contributor

@ginnwork the RETURNING clause is specific to Postgres, can you make this non-generic so it only applies to the applicable dialect(s) and can be overridden as needed?

@ginnwork
Copy link
Author

I updated the pull request with the changes @nick-w-nick suggested and added the tests @pi0 requested.

Was there any other changes needed to merge this pull request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support RETURNING Clause
3 participants