fix(fontless): emitFile during transform #653
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
problem
When using "shared plugin mode" during build https://vite.dev/guide/api-environment-plugins.html#shared-plugins-during-build, plugin's
assetContext.renderedFontURLs
state is shared between all environment builds and it causesemitFile
duringgenerateBundle
to doubly/triply output font assets on unrelated environments. For example, this is the case on@vitejs/plugin-rsc
based app and it currently causes css and font processed onrsc
environment to cause other environments to also write font files.solution
This PR moves
emitFile
fromgenerateBundle
toassetContext.callback
, which is called only whentransformCss
found a relevant assets and this avoids generating fonts in an unrelated environment.