-
-
Notifications
You must be signed in to change notification settings - Fork 41
feat: category-aware default fallbacks #674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
❌ Deploy Preview for fontless failed.
|
commit: |
9af3f73
to
6d0fa33
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #674 +/- ##
==========================================
- Coverage 53.40% 53.08% -0.32%
==========================================
Files 11 11
Lines 734 729 -5
Branches 93 93
==========================================
- Hits 392 387 -5
Misses 342 342 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we do something similar in fontless. maybe we could export the shared/overlapping utils or defaults from fontaine so we could share?
fix: typo in test description fix: lowercase describe block per linter
934c7ec
to
985453b
Compare
Refactored! |
Fixes #544
Automatic font fallback selection based on font categories (serif, sans-serif, monospace). Maintains full backward compatibility.
Changes
categoryFallbacks
option for customizationFontFaceMetrics
with optionalcategory
field