Add fontaine CLI entrypoint#757
Open
AgentGoose32 wants to merge 5 commits into
Open
Conversation
✅ Deploy Preview for fontless ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughAdds a Node ESM CLI and programmatic entrypoint: Changes
Sequence DiagramsequenceDiagram
participant User as User/CLI
participant CLI as packages/fontaine/src/cli.ts
participant FS as File System
participant Transform as FontaineTransform
participant Output as Output File
User->>CLI: Run `fontaine input.css [output.css]`
CLI->>CLI: Parse args, validate input
CLI->>FS: Read input CSS file
FS-->>CLI: Return CSS content
CLI->>Transform: Create/normalize plugin (resolvePath / fallbacks)
CLI->>Transform: Invoke transform.handler(source, inputPath)
Transform-->>CLI: Return transformed result
CLI->>CLI: Choose output path (explicit or .fontaine.css)
CLI->>FS: Ensure parent directories exist
CLI->>Output: Write transformed CSS (or original if fallback)
Output-->>CLI: Confirm written
CLI->>User: Print generated filename
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 6/8 reviews remaining, refill in 9 minutes and 55 seconds.Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
packages/fontaine/src/cli.ts (1)
1-5: Use top-level type-only import for consistency.Per the ESLint
import/consistent-type-specifier-stylerule, prefer a separate type import.🔧 Proposed fix
#!/usr/bin/env node import { existsSync, mkdirSync, readFileSync, writeFileSync } from 'node:fs' import { basename, dirname, resolve } from 'node:path' import { pathToFileURL } from 'node:url' -import { FontaineTransform, type FontaineTransformOptions } from './transform' +import type { FontaineTransformOptions } from './transform' +import { FontaineTransform } from './transform'🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@packages/fontaine/src/cli.ts` around lines 1 - 5, The import line mixes a value and a type; change it to use a top-level type-only import for FontaineTransformOptions by separating the imports from './transform' so that FontaineTransform is imported as a value and FontaineTransformOptions is imported with the type-only specifier (reference symbols: FontaineTransform, FontaineTransformOptions, import from './transform').
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@packages/fontaine/src/cli.ts`:
- Line 27: The outputPath computation can accidentally equal inputPath when the
input extension isn't exactly ".css" (case-sensitive), causing overwrites;
update the logic that sets outputPath (currently using output ? resolve(output)
: inputPath.replace(/\.css$/, '.fontaine.css')) to instead build the output
filename in a case-insensitive and extension-agnostic way—use Node's path
utilities (e.g., path.parse/path.format or path.extname) to replace the input
file's extension with ".fontaine.css" when output is not provided, or apply a
case-insensitive regex like /\.[^.]+$/i to strip the extension before appending
".fontaine.css", keeping resolve(output) behavior when output is provided.
In `@packages/fontaine/src/index.ts`:
- Around line 6-7: Move the exports from './cli' (export { transformCssFile }
and export type { FontaineCliOptions }) so they appear before the './metrics'
exports in the index export list to satisfy the perfectionist/sort-exports
ESLint rule; locate the export statements for transformCssFile and
FontaineCliOptions and reorder them to be placed above any exports coming from
'./metrics'.
---
Nitpick comments:
In `@packages/fontaine/src/cli.ts`:
- Around line 1-5: The import line mixes a value and a type; change it to use a
top-level type-only import for FontaineTransformOptions by separating the
imports from './transform' so that FontaineTransform is imported as a value and
FontaineTransformOptions is imported with the type-only specifier (reference
symbols: FontaineTransform, FontaineTransformOptions, import from
'./transform').
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 71445b53-7d0e-4120-bc76-e2c556cad245
📒 Files selected for processing (5)
packages/fontaine/README.mdpackages/fontaine/package.jsonpackages/fontaine/src/cli.tspackages/fontaine/src/index.tspackages/fontaine/tsdown.config.ts
There was a problem hiding this comment.
♻️ Duplicate comments (1)
packages/fontaine/src/cli.ts (1)
35-38:⚠️ Potential issue | 🟠 MajorPrevent accidental source-file overwrite when deriving default output path.
At Line 35, the fallback path replacement only matches lowercase
.css. For inputs likestyles.CSS(or non-.cssfiles),outputPathcan equalinputPath, and Line 38 will overwrite the original file.🐛 Proposed fix
- const outputPath = output ? resolve(output) : inputPath.replace(/\.css$/, '.fontaine.css') + const outputPath = output + ? resolve(output) + : inputPath.replace(/\.[^.]+$/i, '.fontaine.css') + + if (!output && outputPath === inputPath) { + throw new Error(`Cannot determine output path for "${input}". Please specify an output path.`) + }🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@packages/fontaine/src/cli.ts` around lines 35 - 38, The current fallback that computes outputPath from inputPath only replaces lowercase ".css", which can leave outputPath equal to inputPath for inputs like "styles.CSS" and cause writeFileSync to overwrite the source; update the logic that derives outputPath (the code computing outputPath from inputPath) to perform a case-insensitive extension replacement (e.g., use a case-insensitive regex like /\.css$/i) or, more robustly, use path.extname/path.basename to detect the extension and produce a distinct filename (e.g., replace .css case-insensitively or append ".fontaine.css" when no .css extension), and add a safety check before calling writeFileSync to ensure outputPath !== inputPath and fail or alter the name if they are equal.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Duplicate comments:
In `@packages/fontaine/src/cli.ts`:
- Around line 35-38: The current fallback that computes outputPath from
inputPath only replaces lowercase ".css", which can leave outputPath equal to
inputPath for inputs like "styles.CSS" and cause writeFileSync to overwrite the
source; update the logic that derives outputPath (the code computing outputPath
from inputPath) to perform a case-insensitive extension replacement (e.g., use a
case-insensitive regex like /\.css$/i) or, more robustly, use
path.extname/path.basename to detect the extension and produce a distinct
filename (e.g., replace .css case-insensitively or append ".fontaine.css" when
no .css extension), and add a safety check before calling writeFileSync to
ensure outputPath !== inputPath and fail or alter the name if they are equal.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 847cf8d5-0149-4c34-a9a0-329bd2e4b892
📒 Files selected for processing (1)
packages/fontaine/src/cli.ts
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@packages/fontaine/src/cli.ts`:
- Around line 35-36: The code assigns code using || which treats an empty-string
transform output as missing; update the assignment that sets code (the line
using transformed and source) to use nullish coalescing so only null/undefined
fall back to source—i.e., when calling transform.handler.call and inspecting the
resulting transformed value (variable transformed), keep empty string results
instead of replacing them with source by using ?? rather than ||.
- Around line 67-79: The CLI currently ignores extra positional args after the
expected two; update the argument handling in packages/fontaine/src/cli.ts to
fail fast when more than two positional arguments are present: after
destructuring const [input, output] = args, check if args.length > 2 and if so
print an error like "Unexpected positional arguments: <list>" (or similar), set
process.exitCode = 1 and return; keep the existing checks for missing input and
missing file (existsSync) unchanged—use the existing args/input/output
identifiers to locate where to insert this validation.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 4a445b83-3e68-400a-b4a7-f98a31eb5974
📒 Files selected for processing (2)
packages/fontaine/src/cli.tspackages/fontaine/src/index.ts
✅ Files skipped from review due to trivial changes (1)
- packages/fontaine/src/index.ts
Author
|
Fixed the latest CodeRabbit findings in
Validation:
|
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@packages/fontaine/src/cli.ts`:
- Around line 25-28: The default fallbacks value is being overwritten by the
spread of options (so callers passing { fallbacks: undefined } nullify the CLI
default), so update the object passed to FontaineTransform.rollup to derive
fallbacks from options using a nullish-coalescing check (e.g. use
options.fallbacks ?? ['Arial'] or place fallbacks after the spread) and keep the
existing resolvePath logic; locate the call to FontaineTransform.rollup (the
plugin variable) and replace the current spread pattern with one that ensures
fallbacks defaults to ['Arial'] when options.fallbacks is null or undefined to
preserve behavior for transformCssFile().
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 5a4759db-3ab9-4ba7-a658-458a6fc1f286
📒 Files selected for processing (1)
packages/fontaine/src/cli.ts
Author
|
Fixed the latest CodeRabbit finding in Validation:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a first CLI entrypoint for
fontaineso the package can be used directly against a CSS file without wiring up Vite/Webpack/Rollup.Changes:
src/cli.tswithfontaine <input.css> [output.css]package.jsonbintsdownsodist/cli.mjsis built with a shebang and execute bittransformCssFile()for programmatic usageTesting
pnpm --filter fontaine buildnode packages/fontaine/dist/cli.mjs --helppnpm --filter fontaine test:typesgit diff --checkNote:
pnpm --filter fontaine test:unitcurrently fails locally due 12 pre-existing inline snapshot mismatches unrelated to this CLI entrypoint. The CLI build/typecheck/help-path validation above passes.Fixes #17
Summary by CodeRabbit
New Features
Documentation