Skip to content

fix: type origin-trial meta directive - #932

Merged
harlan-zw merged 1 commit into
mainfrom
feat/origin-trial-meta-type
Aug 4, 2026
Merged

fix: type origin-trial meta directive#932
harlan-zw merged 1 commit into
mainfrom
feat/origin-trial-meta-type

Conversation

@harlan-zw

@harlan-zw harlan-zw commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator

🔗 Linked issue

None.

❓ Type of change

  • 📖 Documentation
  • 🐞 Bug fix
  • 👌 Enhancement
  • ✨ New feature
  • 🧹 Chore
  • ⚠️ Breaking change

📚 Description

The http-equiv type accepted custom strings, but editor autocomplete omitted origin-trial. Add it to the strict and generic meta value unions.

Summary by CodeRabbit

  • New Features
    • Added support for the origin-trial value in HTTP-equivalent metadata definitions.
    • Improved compatibility with pages using origin trial browser features.

@harlan-zw harlan-zw changed the title feat: type origin-trial meta directive fix: type origin-trial meta directive Aug 4, 2026
@coderabbitai

coderabbitai Bot commented Aug 4, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 5f76b7ec-0386-4bcc-a2f6-0872ce7a2593

📥 Commits

Reviewing files that changed from the base of the PR and between cc1e03b and c70077b.

📒 Files selected for processing (2)
  • packages/unhead/src/types/schema/head.ts
  • packages/unhead/src/types/schema/meta.ts

📝 Walkthrough

Walkthrough

The change adds 'origin-trial' to the accepted http-equiv values in MetaGeneric and HttpEquivMeta.

Changes

Origin trial meta types

Layer / File(s) Summary
Extend HTTP equivalent type contracts
packages/unhead/src/types/schema/head.ts, packages/unhead/src/types/schema/meta.ts
Both exported type declarations now accept the 'origin-trial' literal for http-equiv.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the type fix for the origin-trial meta directive.
Description check ✅ Passed The description includes the linked issue, change type, and a clear explanation of the autocomplete problem and solution.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/origin-trial-meta-type

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

📦 Bundle Size

No notable changes

All bundles (14)
Bundle Gzipped Brotli Raw
Core
Client (Minimal) 5.4 kB 4.9 kB 13.6 kB
Client (Full) 9.6 kB 8.8 kB 25.2 kB
Client (Self-Contained) 5.7 kB 5.1 kB 14.3 kB
Server (Minimal) 4.9 kB 4.4 kB 12.3 kB
Server (Self-Contained) 5.2 kB 4.7 kB 13 kB
Vue
Vue Client (Minimal) 5.9 kB 5.3 kB 14.6 kB
Vue Client (Full) 10.7 kB 9.7 kB 28 kB
Vue Server (Minimal) 5.4 kB 4.9 kB 13.4 kB
React
React Client (Minimal) 5.8 kB 5.3 kB 14.7 kB
React Client (Full) 10.8 kB 9.8 kB 28.4 kB
React Server (Minimal) 5.2 kB 4.7 kB 13 kB
Schema.org
Schema.org (Minimal) 11.7 kB 10.5 kB 34.2 kB
Schema.org Imports 0.1 kB 0.1 kB 0.1 kB
Schema.org Vue Meta 0.5 kB 0.4 kB 1 kB

📦 Runtime Dependencies

No runtime dependency changes

All packages (10)
Package External deps Install size Largest dependency Skipped optional
@unhead/angular 10 773.6 kB @jridgewell/trace-mapping 146.7 kB 0
@unhead/bundler 10 786.9 kB @jridgewell/trace-mapping 146.7 kB 0
@unhead/cli 18 4.4 MB @oxc-parser/binding-linux-arm64-gnu 2 MB 19
@unhead/eslint-plugin 9 683.2 kB @jridgewell/trace-mapping 146.7 kB 0
@unhead/react 11 810.7 kB @jridgewell/trace-mapping 146.7 kB 0
@unhead/schema-org 9 683.2 kB @jridgewell/trace-mapping 146.7 kB 0
@unhead/solid-js 11 810.7 kB @jridgewell/trace-mapping 146.7 kB 0
@unhead/svelte 11 810.7 kB @jridgewell/trace-mapping 146.7 kB 0
@unhead/vue 11 810.7 kB @jridgewell/trace-mapping 146.7 kB 0
unhead 9 683.2 kB @jridgewell/trace-mapping 146.7 kB 0
Skipped optional dependencies (19)
  • @unhead/cli: oxc-parser -> @oxc-parser/binding-android-arm-eabi, oxc-parser -> @oxc-parser/binding-android-arm64, oxc-parser -> @oxc-parser/binding-darwin-arm64, oxc-parser -> @oxc-parser/binding-darwin-x64, oxc-parser -> @oxc-parser/binding-freebsd-x64, oxc-parser -> @oxc-parser/binding-linux-arm-gnueabihf, oxc-parser -> @oxc-parser/binding-linux-arm-musleabihf, oxc-parser -> @oxc-parser/binding-linux-arm64-musl, oxc-parser -> @oxc-parser/binding-linux-ppc64-gnu, oxc-parser -> @oxc-parser/binding-linux-riscv64-gnu, oxc-parser -> @oxc-parser/binding-linux-riscv64-musl, oxc-parser -> @oxc-parser/binding-linux-s390x-gnu, oxc-parser -> @oxc-parser/binding-linux-x64-gnu, oxc-parser -> @oxc-parser/binding-linux-x64-musl, oxc-parser -> @oxc-parser/binding-openharmony-arm64, oxc-parser -> @oxc-parser/binding-wasm32-wasi, oxc-parser -> @oxc-parser/binding-win32-arm64-msvc, oxc-parser -> @oxc-parser/binding-win32-ia32-msvc, oxc-parser -> @oxc-parser/binding-win32-x64-msvc

Production dependencies only. Peer dependencies and Unhead workspace packages are excluded. Skipped optional dependencies are unavailable on the CI platform.


⚡ Performance (directional)

🟢 1 faster

Benchmark base → PR Δ
Bundler: ssrStaticReplace skip unrelated code 0.002 ms → 0.002 ms 🟢 -5.2%
All benchmarks (25)
Benchmark PR Δ RME
SSR render (CPU) 0.361 ms ~ noise ±9.6%
SSR render (wall) 0.263 ms ~ noise ±4.9%
SSR allocated / render 242.8 KiB ~ noise ±5.8%
Schema.org cached render (CPU) 0.355 ms ~ noise ±6.6%
Schema.org cached render (wall) 0.254 ms ~ noise ±2.8%
Schema.org cached allocated / render 139.1 KiB ~ noise ±0.8%
Streaming wrapStream drain (CPU) 0.239 ms ~ noise ±4.9%
Streaming wrapStream drain (wall) 0.153 ms ~ noise ±5.1%
Streaming allocated / drain 149.8 KiB ~ noise ±0.2%
Streaming suspense chunk (CPU) 0.013 ms ~ noise ±9.5%
Streaming allocated / suspense chunk 5.1 KiB ~ noise ±0.5%
CSR DOM mutations / nav 38 ~ noise
CSR re-render (CPU) 0.859 ms ~ noise ±5.0%
CSR re-render (wall) 0.487 ms ~ noise ±2.2%
Bundler: transformInclude mixed ids 0.409 ms ~ noise ±1.7%
Bundler: useSeoMetaTransform static calls 3.585 ms ~ noise ±4.3%
Bundler: minifyTransform inline script/style 0.525 ms ~ noise ±3.7%
Bundler: treeshakeServerComposables many calls 2.605 ms ~ noise ±6.1%
Bundler: treeshakeServerComposables skip unrelated code 0.002 ms ~ noise ±1.0%
Bundler: ssrStaticReplace many head.ssr reads 1.658 ms ~ noise ±6.7%
Bundler: ssrStaticReplace skip unrelated code 0.002 ms 🟢 -5.2% ±0.5%
Bundler: createHeadTransform many createHead calls 0.599 ms ~ noise ±5.0%
Bundler: react streaming skip JSX without head calls 0.003 ms ~ noise ±1.4%
Bundler: react streaming transform JSX with head calls 1.604 ms ~ noise ±6.5%
Bundler: solid streaming skip JSX without head calls 0.003 ms ~ noise ±1.2%

Baseline: main @ cc1e03b · 2026-08-04 · gzipped is the headline size metric · perf is directional (shared-runner, gated)

@harlan-zw
harlan-zw merged commit 3cdeae3 into main Aug 4, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant