feat: better validation errors - #6848
Draft
Flo4604 wants to merge 1 commit into
Draft
Conversation
Flo4604
force-pushed
the
flo-spec-redaction
branch
from
July 27, 2026 10:39
5ed47f3 to
e3ec671
Compare
Flo4604
force-pushed
the
flo-validation-errors
branch
from
July 27, 2026 12:09
b3f7cf4 to
db15d21
Compare
Flo4604
force-pushed
the
flo-validation-errors
branch
from
July 27, 2026 12:19
db15d21 to
11ca4b2
Compare
Flo4604
force-pushed
the
flo-validation-errors
branch
from
July 27, 2026 12:45
11ca4b2 to
6a7271c
Compare
Flo4604
force-pushed
the
flo-validation-errors
branch
from
July 27, 2026 15:55
6a7271c to
2d4809f
Compare
Flo4604
force-pushed
the
flo-validation-errors
branch
from
July 27, 2026 16:04
2d4809f to
622d378
Compare
Validation errors named the schema keyword pointer rather than the field that
failed, reported only the first of a request's problems, and were assembled by
regex over the library's prose. Messages are now built from jsonschema's typed
error kinds, reading only the constraint side, so location points at the caller's
field and every failure is reported.
before /properties/variables/items/properties/value/pattern
does not satisfy 'pattern'
after body.variables[1].key
must match the pattern '^[A-Za-z_][A-Za-z0-9_]*$'
Flo4604
force-pushed
the
flo-validation-errors
branch
from
July 27, 2026 16:10
622d378 to
4d02c53
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
Our validation errors dont read nicely
Solution:
Write custom error messages instead of relying on the ones we get from our openapi pkg.
Impact:
None
Testing:
Tests should pass + there is a file showing all the new validation errors with before/after.