Feat/options reset confirmation & quit confirmation#146
Open
flyingmongoose wants to merge 1 commit intounknown-horizons:developfrom
Open
Feat/options reset confirmation & quit confirmation#146flyingmongoose wants to merge 1 commit intounknown-horizons:developfrom
flyingmongoose wants to merge 1 commit intounknown-horizons:developfrom
Conversation
Introduce a shared parchment (notice230) modal with dimmer, Fife-aligned copy and layout, and round OK/Cancel controls. Gate in-app quit on PlatformPolicy for iOS/Android store compliance (no quit UI, no quit_game handling). Options factory reset uses the same modal; main menu and Global quit_game use it on desktop only.
flyingmongoose
force-pushed
the
feat/options-reset-confirmation
branch
from
9b4ab30 to
f007f30
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementing a confirmation modal is easy enough, so I did so.
It's currently working on options/settings reset, and on Quit confirmation.
It's slightly different from the fife-engine version, where mine just dims the current display, but this is actually what is usually expected in "modern games". Though, if desired, I can definitely make it "hide the other UI".
Additionally, I noticed that there seems to be some references to maybe distributing on mobile devices in the future in some of the code. And the "Compatibility" graphics option also supports that on Godot (as Future is recommended only for desktop).
I have published games to the Google Play Store, I got denied one early publish by having a "Quit button at all". So I have conditions that will remove the display of the quit button if it's on mobile.