Skip to content

fix: Background for Tabbar Icon#1043

Open
Darsh0307 wants to merge 3 commits intomasterfrom
dev/dp/Background
Open

fix: Background for Tabbar Icon#1043
Darsh0307 wants to merge 3 commits intomasterfrom
dev/dp/Background

Conversation

@Darsh0307
Copy link
Contributor

GitHub Issue (If applicable): closes #1032

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting)
  • Refactoring (no functional changes, no api changes)
  • Build or CI related changes
  • Documentation content changes
  • Project automation
  • Other... Please describe:

What is the current behavior?

Tabbar-For Material Top TabBar sample Page' the tab Icon and text color is not changing for dark theme

What is the new behavior?

The Text and Icon color should change to black color for dark theme or the whole screen should change in black color.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested on iOS.
  • Tested on Wasm.
  • Tested on Android.
  • Tested on UWP.
  • Tested in both Light and Dark themes.
  • Associated with an issue (GitHub or internal)

Other information

Internal Issue (If applicable):

@Darsh0307 Darsh0307 self-assigned this Nov 3, 2023
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ Darsh0307
❌ Darsh Patel


Darsh Patel seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://white-field-08c5cf00f-1043.eastus2.3.azurestaticapps.net

@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://white-field-08c5cf00f-1043.eastus2.3.azurestaticapps.net

@@ -42,32 +42,32 @@
<Grid x:Name="Home" Visibility="Collapsed">
<Border Background="LightGray">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This Background needs to be set to {ThemeResource SurfaceBrush} instead of LightGray

</Border>
</Grid>
<Grid x:Name="Search" Visibility="Collapsed">
<Border Background="LightGray">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This Background needs to be set to {ThemeResource SurfaceBrush} instead of LightGray

</Border>
</Grid>
<Grid x:Name="Support" Visibility="Collapsed">
<Border Background="LightGray">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This Background needs to be set to {ThemeResource SurfaceBrush} instead of LightGray

</Border>
</Grid>
<Grid x:Name="About" Visibility="Collapsed">
<Border Background="LightGray">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This Background needs to be set to {ThemeResource SurfaceBrush} instead of LightGray

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Gallery][Wasm]Tabbar-For Material Top TabBar sample Page' the tab Icon and text color is not changing for dark theme.

3 participants