Commit 18b7f12
refactor(fit-app): address second code-quality pass on #930
- WeeklyRing.UpdateArc: assign the new PathGeometry directly to ArcPath.Data
instead of via a throwaway local (the Path owns it; the previous geometry is
still disposed before replacement) — clears the "IDisposable not disposed" flag.
- Shell.StartupLoadable.Begin: drop the defensive generic catch around
Task.Delay. A constant delay with no cancellation token cannot throw; the
splash-dismissal guarantee is the TryEnqueue/Complete fallback, which stays.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>1 parent 4d37d41 commit 18b7f12
2 files changed
Lines changed: 7 additions & 15 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
39 | 39 | | |
40 | 40 | | |
41 | 41 | | |
42 | | - | |
43 | | - | |
44 | | - | |
45 | | - | |
46 | | - | |
47 | | - | |
48 | | - | |
49 | | - | |
| 42 | + | |
50 | 43 | | |
51 | | - | |
52 | | - | |
| 44 | + | |
| 45 | + | |
53 | 46 | | |
54 | 47 | | |
55 | 48 | | |
| |||
Lines changed: 4 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
161 | 161 | | |
162 | 162 | | |
163 | 163 | | |
164 | | - | |
165 | | - | |
166 | | - | |
167 | | - | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
168 | 167 | | |
169 | | - | |
| 168 | + | |
170 | 169 | | |
171 | 170 | | |
172 | 171 | | |
| |||
0 commit comments