docs(MVUX): Warn user to not use ItemClickCommand on ListView at the same time as Selection - #2923
Closed
DevTKSS wants to merge 4 commits into
Closed
docs(MVUX): Warn user to not use ItemClickCommand on ListView at the same time as Selection#2923DevTKSS wants to merge 4 commits into
DevTKSS wants to merge 4 commits into
Conversation
…same time as Selection
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Selection.md documentation file by fixing the YAML front matter formatting and adding new warning and note sections about ListView selection behavior and GitHub links.
Key changes:
- Corrected the YAML front matter delimiter formatting
- Added a warning about
ItemClickCommandinterfering with theSelectionoperator - Updated GitHub sample repository links to include more descriptive text
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub Issue (If applicable): closes #
PR Type
What kind of change does this PR introduce?
What is the current behavior?
As not introduced into this important detail so far, we may assume that both callbacks (
ListState.Selection&ListView.ItemClickCommand) are invoked if we bind them to the Model, but by setting theItemClickCommandof the FeedView, our ListState does maybe not longer execute both, the callback fromSelection(...)Operator and the commandWhat is the new behavior?
Added this information to the Mvux Selection Docs where we are introduced into the how to use this Method on the ListState, so users can now know about it and avoid this szenario
PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.Other information
If we should instead expect both of them to be executed if set, then please fix this instead!
Internal Issue (If applicable):