docs(KeyEquality): Re-Add KeyEquality Extension to the TOC and fix broken Link in ListStates Updating Operator docs - #2925
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds documentation for the KeyEquality feature and updates cross-references to point to the new documentation structure. The documentation is reorganized to appear under its own section rather than being referenced by an older namespace reference.
- Adds KeyEquality section to the documentation table of contents
- Updates cross-reference links from the old
Uno.Extensions.Equalitynamespace toUno.Extensions.KeyEquality - Reformats the concept.md file (adds line numbers without content changes)
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| doc/toc.yml | Adds KeyEquality section to the documentation navigation |
| doc/Learn/Mvux/ListStates.md | Updates cross-reference link and clarifies that generation applies specifically to records |
| doc/Learn/KeyEquality/concept.md | Reformats file with proper line numbering and minor documentation improvements |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…oken Link in ListStates Updating Operator docs
6152477 to
2d0961e
Compare
|
@kazo0 hey could you maybe check if we can re-attach this docs to our TOC? They are linked in the MVUX yes, meanwhile I recognized that they are just not intended to be used in this, but as exactly this has caused one of the Root problems a User that was watching my videos was facing hand we tryed honestly about 4 hours until we did fall back to either had to use I think I also attached the video on the Bug report if you like to watch fail compilations of beginners 😬 Could be easier for others by this in the future 👍 |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
@kazo0 I noticed that the expected changes to add PropertySelector again into the docs:
|
|
🤔 Maybe - just an idea - but would it maybe make more sense to nest them both under a |
…alitycomparer-not-listed-in-the-toc
GitHub Issue (If applicable): closes #2831
PR Type
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
Extensions>Overview>...TOC branch where I would assume this does belongPR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.Other information
Maybe this Docs of KeyEquality should get split into two or more parts?
Part 1:
[
IKeyEquatable<T>Generation- are there other ways beside Attributes?]
Part 2:
[
]
I am not sure if I did it right in my last application code and this docs page is a bit jumping in reading flow in my opinion. If I would have understand it better I would try to help but...
First you tell us about key equality generally, not using any of them both on the side below. You tell "Name" would be the Key, in the shown szenario, but you dont use any of the attributes and its not named "Key" or "Id" as you state there.
then you come up with the Interface we (assuming) would need to inherit from(?) and the
KeyEqulityComparer<T>...But beside the Attributes you then use the difference is not really getting clear from this. 🤔 If this
KeyEqualityComparer<T>should be reffering to some Microsoft type, then we maybe "just" miss a link we could easily add for clarification, if those MS Docs would then give us the base idea of how you assume us to understand this extension Uno Provides to us 👍Internal Issue (If applicable):