Skip to content

Conversation

@jeromelaban
Copy link
Member

No description provided.

Copilot AI review requested due to automatic review settings December 2, 2025 18:55
Copilot finished reviewing on behalf of jeromelaban December 2, 2025 18:57
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the CI workflow configuration to align with the repository's actual default branch naming. The change updates both push and pull_request triggers from "main" to "uno", making the CI configuration consistent with the branch name already referenced in version.json.

Key changes:

  • Updated CI workflow branch triggers to use "uno" instead of "main"
  • Ensures consistency between CI automation and version control configuration

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings December 2, 2025 19:09
Copilot finished reviewing on behalf of jeromelaban December 2, 2025 19:10
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings December 2, 2025 19:20
@jeromelaban jeromelaban merged commit cffa9c9 into uno Dec 2, 2025
2 of 3 checks passed
Copilot finished reviewing on behalf of jeromelaban December 2, 2025 19:23
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

- name: Build solution
run: dotnet build MonacoEditorComponent.slnx -c Release -p:ArtifactsPath="$ARTIFACTS_DIR" /bl:"$ARTIFACTS_DIR/log/build.binlog"
run: dotnet build MonacoEditorComponent.slnx -c Release -p:ArtifactsPath="${{ env.ARTIFACTS_DIR }}" /bl:"${{ env.ARTIFACTS_DIR }}/log/build.binlog"
Copy link

Copilot AI Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incorrect environment variable syntax in -p:ArtifactsPath="${{ env.ARTIFACTS_DIR }}". The shell variable expansion syntax ${} is incorrectly wrapping the GitHub Actions expression ${{ env.ARTIFACTS_DIR }}.

GitHub Actions expressions are evaluated before the shell receives the command, so the shell ${} syntax is both unnecessary and potentially problematic. This should be:

run: dotnet build MonacoEditorComponent.slnx -c Release -p:ArtifactsPath="${{ env.ARTIFACTS_DIR }}" /bl:"${{ env.ARTIFACTS_DIR }}/log/build.binlog"

This matches the usage pattern on lines 66, 67, 77, and 85.

Suggested change
run: dotnet build MonacoEditorComponent.slnx -c Release -p:ArtifactsPath="${{ env.ARTIFACTS_DIR }}" /bl:"${{ env.ARTIFACTS_DIR }}/log/build.binlog"
run: dotnet build MonacoEditorComponent.slnx -c Release -p:ArtifactsPath=${{ env.ARTIFACTS_DIR }} /bl:${{ env.ARTIFACTS_DIR }}/log/build.binlog

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants