-
Notifications
You must be signed in to change notification settings - Fork 7
ci: Adjust target branch #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates the CI workflow configuration to align with the repository's actual default branch naming. The change updates both push and pull_request triggers from "main" to "uno", making the CI configuration consistent with the branch name already referenced in version.json.
Key changes:
- Updated CI workflow branch triggers to use "uno" instead of "main"
- Ensures consistency between CI automation and version control configuration
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - name: Build solution | ||
| run: dotnet build MonacoEditorComponent.slnx -c Release -p:ArtifactsPath="$ARTIFACTS_DIR" /bl:"$ARTIFACTS_DIR/log/build.binlog" | ||
| run: dotnet build MonacoEditorComponent.slnx -c Release -p:ArtifactsPath="${{ env.ARTIFACTS_DIR }}" /bl:"${{ env.ARTIFACTS_DIR }}/log/build.binlog" |
Copilot
AI
Dec 2, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Incorrect environment variable syntax in -p:ArtifactsPath="${{ env.ARTIFACTS_DIR }}". The shell variable expansion syntax ${} is incorrectly wrapping the GitHub Actions expression ${{ env.ARTIFACTS_DIR }}.
GitHub Actions expressions are evaluated before the shell receives the command, so the shell ${} syntax is both unnecessary and potentially problematic. This should be:
run: dotnet build MonacoEditorComponent.slnx -c Release -p:ArtifactsPath="${{ env.ARTIFACTS_DIR }}" /bl:"${{ env.ARTIFACTS_DIR }}/log/build.binlog"
This matches the usage pattern on lines 66, 67, 77, and 85.
| run: dotnet build MonacoEditorComponent.slnx -c Release -p:ArtifactsPath="${{ env.ARTIFACTS_DIR }}" /bl:"${{ env.ARTIFACTS_DIR }}/log/build.binlog" | |
| run: dotnet build MonacoEditorComponent.slnx -c Release -p:ArtifactsPath=${{ env.ARTIFACTS_DIR }} /bl:${{ env.ARTIFACTS_DIR }}/log/build.binlog |
No description provided.