ci: Adjust publish #34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR refactors the NuGet package publishing process in the GitHub Actions workflow by replacing the previous two-step approach (adding a source, then pushing) with a streamlined single-step push command using environment variables for configuration.
Key Changes:
- Replaced explicit source addition with environment variable configuration
- Consolidated two
dotnet nugetcommands into a single push command - Added
--skip-duplicateflag to handle existing packages gracefully
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| run: | | ||
| dotnet nuget add source https://pkgs.dev.azure.com/uno-platform/1dd81cbd-cb35-41de-a570-b0df3571a196/_packaging/unoplatformdev/nuget/v3/index.json -n "dev" --username az --password "${{ inputs.token }}" --store-password-in-clear-text | ||
| dotnet nuget push --api-key AZ -s dev artifacts/*.nupkg | ||
| dotnet nuget push artifacts/*.nupkg --source $env:FEED_ENDPOINT --api-key az --skip-duplicate |
There was a problem hiding this comment.
The API key 'az' appears to be a placeholder or incorrect value. Azure DevOps feeds typically require the actual token value as the API key. Consider using ${{ inputs.token }} as the API key value instead of 'az'.
Suggested change
| dotnet nuget push artifacts/*.nupkg --source $env:FEED_ENDPOINT --api-key az --skip-duplicate | |
| dotnet nuget push artifacts/*.nupkg --source $env:FEED_ENDPOINT --api-key "${{ inputs.token }}" --skip-duplicate |
Copilot finished reviewing on behalf of
jeromelaban
December 3, 2025 15:50
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.