Allow specifying BindingMode in AncestorBinding
#1384
+36
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Nice! Thank you for the PR @ProphetLamb! And for the added tests, very much appreciated :) Will ping @Xiaoy312 to double-check this just in case :) |
Xiaoy312
reviewed
May 1, 2025
There was a problem hiding this comment.
the newly added doesnt verify the nature of the binding (being two-ways)
you should either retrieve the binding on the property and assert its mode, or
change the destination value and validate if the source value is updated as a result
preferably both
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue (If applicable): #
PR Type
What kind of change does this PR introduce?
What is the current behavior?
AncestorBindingalways binds usingBindingMode.OneWay.What is the new behavior?
AncestorBindingalways binds usingBindingMode.OneWayunless specified otherwise.AncestorBindingallows specifying a desiredModediverging from the default behaviour.This change is non-breaking.
PR Checklist
Please check if your PR fulfills the following requirements:
Other information
I've been using a copy of
AncestorBindingwith this change for a while. Thought I'd contribute it, if wanted.Tests for mobile platforms are pending, because I'm developing for Web & Desktop only.
Internal Issue (If applicable):