Skip to content

fix: RegisterName in NameScope when entering the visual tree and fix ElementName bindings #16976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

fix: RegisterName in NameScope when entering the visual tree and fix ElementName bindings #16976

wants to merge 5 commits into from

Conversation

Youssef1313
Copy link
Member

GitHub Issue (If applicable): closes #

PR Type

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

@github-actions github-actions bot added the area/code-generation Categorizes an issue or PR as relevant to code generation label Jun 3, 2024
@Youssef1313 Youssef1313 force-pushed the csm733-2 branch 5 times, most recently from 846acf0 to 36b8b41 Compare June 3, 2024 07:54
@Youssef1313 Youssef1313 marked this pull request as draft June 3, 2024 08:15
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16976/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16976/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16976/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16976/index.html

2 similar comments
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16976/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16976/index.html

MartinZikmund
MartinZikmund approved these changes Jun 4, 2024
View reviewed changes
Copy link
Member

@MartinZikmund MartinZikmund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16976/index.html

@Youssef1313
Copy link
Member Author

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16976/index.html

@github-actions GitHub Actions
Copy link

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or it will be closed in 10 days.

@github-actions github-actions bot added the stale This item has been marked as stale and will be closed if there is no activity. label Feb 12, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 5, 2025

This PR was closed because it has been stalled for 10 days with no activity.

@github-actions github-actions bot closed this Apr 5, 2025
@MartinZikmund MartinZikmund removed the stale This item has been marked as stale and will be closed if there is no activity. label Apr 7, 2025
@MartinZikmund MartinZikmund reopened this Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinZikmund MartinZikmund MartinZikmund approved these changes

Assignees
No one assigned
Labels
area/code-generation Categorizes an issue or PR as relevant to code generation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Youssef1313 @unodevops @MartinZikmund