-
Notifications
You must be signed in to change notification settings - Fork 781
fix: Ensure x:Uid is set only when both name and namespace are correct #19148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
fix: Ensure x:Uid is set only when both name and namespace are correct #19148
Conversation
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-19148/index.html |
🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-19148/index.html |
|
src/SourceGenerators/Uno.UI.SourceGenerators/XamlGenerator/XamlFileGenerator.cs
Show resolved
Hide resolved
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-19148/index.html |
Is there anything I can do to help move this forward? |
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-19148/index.html |
🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-19148/index.html |
|
@AndrewKeepCoding it seems the runtime tests are currently failing, can you try? |
@MartinZikmund I'll take a look in a few days. 🙂 |
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-19148/index.html |
|
🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-19148/index.html |
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-19148/index.html |
|
GitHub Issue (If applicable): closes #19069
PR Type
What kind of change does this PR introduce?
What is the current behavior?
When a custom attached property with the name
Uid
is attached to an element,x:Uid
might be associated with the target instead. This occurs becausex:Uid
is linked to an element solely by its name, not by both name and namespace.What is the new behavior?
x:Uid
won't be linked to an element unless both name and namespace are correctPR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Run
results.Other information
Internal Issue (If applicable):