-
Notifications
You must be signed in to change notification settings - Fork 781
Docs(docfx): update docfx build locally guide and enhance check-toc capabilitys #19722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Docs(docfx): update docfx build locally guide and enhance check-toc capabilitys #19722
Conversation
|
The markdown linting pipeline in this case would be greatly more helpful if it would also lint and suggest the solution for image video and links like relative paths and so on before the intending and spaces checks👍🤔 |
|
Currently on Fixing a regex bug, then I will send the updated commits. |
Does a include of Pester tests required check the ui tests checkbook above? |
@DevTKSS Thank you so much for the Pull Request ❤️ |
Status update: Things might to consider for add able tests and function for uid-xref links:
Currently checking on the dot sourcing third script now which should be last before again check on the main script which uses them. The dot sourcing one might be the most difficult one to setup test for because it has no actual function definition right now, just what it should execute. If it works but test setup has still trouble with its validation I would consider updating the related docs on it and commit to the remote branch so its review-able and maybe get a overseen solution for this. Since I did add those md files, I did sort them into directory and recognized that not really matching and seperated directorys. Seems like there is the main contributing one and the uno-development one which mainly contains all of the files nested in toc contributing😅 And I am thinking of, if the scripts might be better places to the testscrips folder instead(paths naturally fitted) to not cloud the documentation itself? |
@agneszitte @MartinZikmund commited to remote, unable to fix the Import-TocCheckerUtils.Test.ps1 to pass the check of Get-MarkdownHeader function, while it passed the dot-sourcing before. checking this here:
It should have been able to get it from my point of view. |
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-19722/index.html |
Some planned to-do at the moment:
maybe toc checker can be adjusted to exclude the Readme files which are not cared about in samples, but preferred should be, to add explanation and how to each so it would greatly enhance others to learn from there. The xref could be better especially because the external area do have quite long paths otherwise. |
doc/articles/contributing/guidelines/creating-ps-pester-tests.md
Outdated
Show resolved
Hide resolved
doc/articles/contributing/guidelines/creating-ps-pester-tests.md
Outdated
Show resolved
Hide resolved
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-19722/index.html |
work still in progress |
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-19722/index.html |
1 similar comment
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-19722/index.html |
@agneszitte three back- questions added to your comments, you might have an answer to? I am on doing throught file to file to validate and xref the links first in the contribution area so would be great if I could implement those changes then in one go: First comment of yours that's having relevant question to this, would be the links to the dot prefixes templates you said to possibly update to xref. I am not sure if linking that directly with xref would result in a valid link, does that work? Second one is the abbreviation things which are somehow strangely do not show correctly as their docs are telling🤔 If that markdig extension does generally not work on uno docs, that should Maybe better get deleted from the docfx.json also beside not using it in the docs itself? Third one, the possible scripts namespace I would maybe better want to change to |
Where did now that uwp-conversions.md file suddenly come from, that's causing merge conflict... |
… formatted blockquotes beside note
added step to dotnet and helpfull links to the configuration and troubleshooting for beginners to improve the start expirience with uno
Co-authored-by: Agnès ZITTE <[email protected]>
Co-authored-by: Agnès ZITTE <[email protected]>
Co-authored-by: Agnès ZITTE <[email protected]>
Co-authored-by: Agnès ZITTE <[email protected]>
Co-authored-by: Agnès ZITTE <[email protected]>
Co-authored-by: Agnès ZITTE <[email protected]>
Co-authored-by: Agnès ZITTE <[email protected]>
…es directory to match their namespace Also added some comments to show the need of layout improvements or resorting of sections to another file would make more sense but is not explicit false as it is currently toc.yml updates for this changes are still in progress
… in Metadata as title in the test to be matched as valid
… trailing whitespaces to not run into CI errors because of this and simplify workflow for contributors on this
…space Only done for those where it made sense derived by their topics
…ts function with exclude of Test only relevant file
Since this extension seems to not work properly in uno docs, it might should get removed from docfx.json
(cherry picked from commit feefa5a25cc9d9d55d2bf7a6dc62bb3dabc57500)
…github.com/DevTKSS/uno into docs(DocFx)-update-run-docfx-locally-guide
🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-19722/index.html |
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-19722/index.html |
|
GitHub Issue (If applicable): closes #
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Current docfx guide is outdated and telling to use docfx.console which has been depreciated
see more Information to this here: dotnet/docfx#9100
Link to the Documentation page
The Uno.Extensions Repository is already having the new commands in its Readme.md
Secondary, the check_toc.ps1 does list almoast every href as not linked to a file, because it does not recognize the xref link declaration
Third page is way smaller changes:
What is the new behavior?
Updated the docfx commands
Problem with that is, I do not understand the UWPSyncGenerator so deeply to decide this. Currently, those comments do stretch the md line distance a bit (vs 2022 preview) althought its hidden.
Added a detailed guide to the usage of check_toc.ps1 along with adding the capability of recognizing and comparing the xref -> uids
The old one does have a different signature...
At the moment it's not part of the CI,
so I dont know it should be tested for this again...PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Run
results. -> building docfx is failing because of missing things it seems to medocfx build output.txt
Other information
Above mentioned
Internal Issue (If applicable):