Skip to content

fix(ComboBox): updated selection not scrolled into view #20204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(ComboBox): updated selection not scrolled into view #20204

wants to merge 1 commit into from
+167 −17

Conversation

Xiaoy312
Copy link
Contributor

@Xiaoy312 Xiaoy312 commented May 6, 2025 •
edited
Loading

GitHub Issue (If applicable): closes unoplatform/kahua-private#293

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

Updates to ComboBox selection does not being the selection into view.

What is the new behavior?

It will now.

PR Checklist

Please check if your PR fulfills the following requirements:

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App 2 stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-20204/wasm-skia-net9/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-20204/docs/index.html

@Xiaoy312 Xiaoy312 force-pushed the dev/xygu/20250506/combo-selection-scrollintoview branch from 7fd6b3e to 3fd5c2a Compare May 6, 2025 22:14
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-20204/docs/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App 2 stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-20204/wasm-skia-net9/index.html

@jeromelaban
Copy link
Member

@Mergifyio backport release/stable/6.0

@mergify Mergify
Copy link
Contributor

mergify bot commented May 7, 2025

backport release/stable/6.0

🟠 Waiting for conditions to match

  • merged [📌 backport requirement]

@Xiaoy312 Xiaoy312 force-pushed the dev/xygu/20250506/combo-selection-scrollintoview branch from 3fd5c2a to f97a070 Compare May 7, 2025 17:28
@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App 2 stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-20204/wasm-skia-net9/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-20204/docs/index.html

@Xiaoy312 Xiaoy312 force-pushed the dev/xygu/20250506/combo-selection-scrollintoview branch from f97a070 to ff6ba64 Compare May 8, 2025 13:54
@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App 2 stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-20204/wasm-skia-net9/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-20204/docs/index.html

@unodevops
Copy link
Contributor

⚠️⚠️ The build 164932 has failed on Uno.UI - CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeromelaban jeromelaban jeromelaban approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Xiaoy312 @unodevops @jeromelaban