-
Notifications
You must be signed in to change notification settings - Fork 788
perf: Implement DependencyPropertyChangedEventArgs pool #20556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-20556/wasm-skia-net9/index.html |
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-20556/docs/index.html |
src/Uno.UI/UI/Xaml/DependencyObjectStore.DependencyPropertyChangedEventArgsPool.cs
Show resolved
Hide resolved
src/Uno.UI/UI/Xaml/DependencyObjectStore.DependencyPropertyChangedEventArgsPool.cs
Show resolved
Hide resolved
The build 166758 found UI Test snapshots differences: Details
|
ca5b32d
to
8dc9370
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are 4 paths that lead to the allocation. The code paths where the eventArgs ??= new DependencyPropertyChangedEventArgs(...)
is reachable.
I'm guessing the most significant path is IDependencyObjectInternal
, which is resolvable in a better way that I implemented earlier but had to revert it in #17414.
🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-20556/wasm-skia-net9/index.html |
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-20556/docs/index.html |
|
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-20556/docs/index.html |
🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-20556/wasm-skia-net9/index.html |
The build 167048 found UI Test snapshots differences: Details
|
The build 167048 found UI Test snapshots differences: Details
|
perf: Implement DependencyPropertyChangedEventArgs pool
PR Type
What kind of change does this PR introduce?
PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Run
results.