Skip to content

Revert rendering changes#21259

Merged
agneszitte merged 3 commits intorelease/stable/6.2from
dev/mazi/revert-rendering
Aug 15, 2025
Merged

Revert rendering changes#21259
agneszitte merged 3 commits intorelease/stable/6.2from
dev/mazi/revert-rendering

Conversation

@MartinZikmund
Copy link
Member

@MartinZikmund MartinZikmund commented Aug 13, 2025

Temporarily reverts #21248, #21189 and #20808

PR Type:

What is the current behavior? 🤔

What is the new behavior? 🚀

PR Checklist ✅

Please check if your PR fulfills the following requirements:

Other information ℹ️

Copilot AI review requested due to automatic review settings August 13, 2025 22:06
@github-actions github-actions bot added platform/wasm 🌐 Categorizes an issue or PR as relevant to the WebAssembly platform platform/android 🤖 Categorizes an issue or PR as relevant to the Android platform platform/macos 🍏 Categorizes an issue or PR as relevant to the macOS platform platform/ios 🍎 Categorizes an issue or PR as relevant to the iOS platform area/skia ✏️ Categorizes an issue or PR as relevant to Skia platform/wpf 🪟 Categorizes an issue or PR as relevant to WPF platform/x11 🐧 Categorizes an issue or PR as relevant to X11 labels Aug 13, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR reverts rendering-related changes made in commit 9b42c81, specifically targeting rendering improvements that were causing issues. The revert focuses on undoing optimizations and features related to UI rendering performance, picture recording, and frame generation control.

  • Reverts picture recording optimization that cached rendering frames in various hosts
  • Removes the feature that delayed frame generation until UI tree arrangement completion
  • Restores direct rendering approach without intermediate picture caching

Reviewed Changes

Copilot reviewed 25 out of 25 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
src/Uno.UI/UI/Xaml/UIElement.cs Removes SetEntireSubtreeDirty method implementation
src/Uno.UI/UI/Xaml/Internal/Scaling/XamlIslandRootScale.mux.cs Comments out call to removed SetEntireSubtreeDirty method
src/Uno.UI/Helpers/SkiaRenderHelper.skia.cs Reverts to simpler rendering helper methods, removes picture recording
src/Uno.UI/FeatureConfiguration.cs Removes GenerateNewFramesOnlyWhenUITreeIsArranged configuration
Multiple host files Removes picture caching and reverts to direct rendering approach
src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Given_TextBlock.cs Removes test case for text binding scenario

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-21259/wasm-skia-net9/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-21259/docs/index.html

@ramezgerges
Copy link
Contributor

Let's not do that. I have a big refactoring that will clean up everything (to be published tomorrow). Let's only revert for the release and keep master as is.

@MartinZikmund MartinZikmund changed the base branch from master to release/stable/6.2 August 14, 2025 05:43
@MartinZikmund MartinZikmund force-pushed the dev/mazi/revert-rendering branch from 8335324 to 0b92312 Compare August 14, 2025 12:39
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-21259/docs/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-21259/wasm-skia-net9/index.html

@unodevops
Copy link
Contributor

⚠️⚠️ The build 173636 has failed on Uno.UI - CI.

@unoplatform unoplatform deleted a comment from mergify bot Aug 14, 2025
@MartinZikmund MartinZikmund force-pushed the dev/mazi/revert-rendering branch from f6672c3 to 049cde8 Compare August 15, 2025 09:51
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-21259/docs/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-21259/wasm-skia-net9/index.html

@unoplatform unoplatform deleted a comment from mergify bot Aug 15, 2025
…/stable/6.2/pr-21189"

This reverts commit 7c8a44a, reversing
changes made to 2bcb265.
…paint_timing"

This reverts commit aa91f5f, reversing
changes made to 6189033.

# Conflicts:
#	src/Uno.UI.Runtime.Skia.AppleUIKit/UI/Xaml/Window/RootViewController.cs
@agneszitte agneszitte force-pushed the dev/mazi/revert-rendering branch from 049cde8 to 9e84c9c Compare August 15, 2025 15:33
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-21259/docs/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-21259/wasm-skia-net9/index.html

@agneszitte agneszitte merged commit 4afaa44 into release/stable/6.2 Aug 15, 2025
72 of 90 checks passed
@agneszitte agneszitte deleted the dev/mazi/revert-rendering branch August 15, 2025 18:28
@mergify
Copy link
Contributor

mergify bot commented Aug 15, 2025

backport release/stable/6.2

✅ Backports have been created

Details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/skia ✏️ Categorizes an issue or PR as relevant to Skia platform/android 🤖 Categorizes an issue or PR as relevant to the Android platform platform/ios 🍎 Categorizes an issue or PR as relevant to the iOS platform platform/macos 🍏 Categorizes an issue or PR as relevant to the macOS platform platform/wasm 🌐 Categorizes an issue or PR as relevant to the WebAssembly platform platform/wpf 🪟 Categorizes an issue or PR as relevant to WPF platform/x11 🐧 Categorizes an issue or PR as relevant to X11

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants