Revert rendering changes#21259
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR reverts rendering-related changes made in commit 9b42c81, specifically targeting rendering improvements that were causing issues. The revert focuses on undoing optimizations and features related to UI rendering performance, picture recording, and frame generation control.
- Reverts picture recording optimization that cached rendering frames in various hosts
- Removes the feature that delayed frame generation until UI tree arrangement completion
- Restores direct rendering approach without intermediate picture caching
Reviewed Changes
Copilot reviewed 25 out of 25 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Uno.UI/UI/Xaml/UIElement.cs | Removes SetEntireSubtreeDirty method implementation |
| src/Uno.UI/UI/Xaml/Internal/Scaling/XamlIslandRootScale.mux.cs | Comments out call to removed SetEntireSubtreeDirty method |
| src/Uno.UI/Helpers/SkiaRenderHelper.skia.cs | Reverts to simpler rendering helper methods, removes picture recording |
| src/Uno.UI/FeatureConfiguration.cs | Removes GenerateNewFramesOnlyWhenUITreeIsArranged configuration |
| Multiple host files | Removes picture caching and reverts to direct rendering approach |
| src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Given_TextBlock.cs | Removes test case for text binding scenario |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
src/Uno.UI.Runtime.Skia.WebAssembly.Browser/ts/Runtime/WebAssemblyWindowWrapper.ts
Show resolved
Hide resolved
src/Uno.UI.Runtime.Skia.WebAssembly.Browser/UI/Xaml/Window/WebAssemblyWindowWrapper.cs
Show resolved
Hide resolved
|
🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-21259/wasm-skia-net9/index.html |
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-21259/docs/index.html |
|
Let's not do that. I have a big refactoring that will clean up everything (to be published tomorrow). Let's only revert for the release and keep master as is. |
8335324 to
0b92312
Compare
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-21259/docs/index.html |
|
🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-21259/wasm-skia-net9/index.html |
|
|
f6672c3 to
049cde8
Compare
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-21259/docs/index.html |
|
🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-21259/wasm-skia-net9/index.html |
049cde8 to
9e84c9c
Compare
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-21259/docs/index.html |
|
🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-21259/wasm-skia-net9/index.html |
✅ Backports have been createdDetails
|
Temporarily reverts #21248, #21189 and #20808
PR Type:
What is the current behavior? 🤔
What is the new behavior? 🚀
PR Checklist ✅
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.Other information ℹ️