-
-
Notifications
You must be signed in to change notification settings - Fork 472
fix(Select): select value flash when selected item #2239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v2
Are you sure you want to change the base?
Conversation
commit: |
|
Please merge this ASAP. This bug is very irritating |
|
@Hwacc what do we need to merge this? this bug irritates the users who use the pages that are consuming this component. |
|
Why is no one updating this PR? Could anyone please work on it? |
|
I’ve resolved the merge conflicts in v2.7.0 and looking forward to review. It looks like quite a few people have run into issues with this Select component. @kricsleo , do we have plans to merge this PR into the next release? Thanks. |
|
Sorry for the late response. I normally don't merge PRs 🙏, so I'll leave it to the author, zernonia. |
📝 Summary
Fix Select component flickering issue
🔗 Related Issues
resolves #2160
🧪 How it was caused
It needs to be traced back to this PR #1916
Using setTimeout to delay and control the rendering flow is a bad solution for handling animation.
The analysis of the causes of the flickering is as follows:
✅ Solutions
Very easy: we fully leverage the
<Presence>component’s features to control the switching of child components.but we need tag
<Presence>asforce-mountto keep it alive, becasue we focus in its child components, don’t want it to be destroyed immediately when closing.In addition, we useforce-mountin<Presence>, so,SelectContentProps's forceMount prop was no longer works. Should we consider removing it?📸 Screenshots
Now, we can use
data-[state=close]to control our close animate as usualForm.default._.Reka.UI.-.Google.Chrome.2025-10-22.17-03-58.mp4