Skip to content

Conversation

@ldelhommeau
Copy link
Contributor

@ldelhommeau ldelhommeau commented Dec 23, 2025

This is an example branch about the focus isse mentionned in #1667 :

When using an input field inside a Dialog that dynamically updates content within the Dialog, the focus keeps switching back to DialogContent, disrupting the user experience.

The reproduction branch is this one: #2331
The fix is here: #2352

What has been patched

See the patch here: #2352

How to reproduce

Expected behaviour

The focus should not be lost.
Here is an example of how it should behave.

Screen.Recording.2025-12-23.at.13.18.50.1.1.mp4

@pkg-pr-new
Copy link

pkg-pr-new bot commented Dec 23, 2025

Open in StackBlitz

npm i https://pkg.pr.new/reka-ui@2353

commit: 305b528

@ldelhommeau ldelhommeau force-pushed the test/shadow-root-focus-issue-patched branch from 0a4e712 to e351e2d Compare December 23, 2025 12:13
@ldelhommeau ldelhommeau force-pushed the test/shadow-root-focus-issue-patched branch 2 times, most recently from b5fe378 to 38dfd4e Compare January 14, 2026 19:32
@coderabbitai
Copy link

coderabbitai bot commented Jan 14, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Comment @coderabbitai help to get the list of available commands and usage tips.

@ldelhommeau ldelhommeau force-pushed the test/shadow-root-focus-issue-patched branch 2 times, most recently from cf9f78e to 3404617 Compare January 15, 2026 10:59
@ldelhommeau ldelhommeau force-pushed the test/shadow-root-focus-issue-patched branch from 3404617 to 305b528 Compare January 16, 2026 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant