chore(ComboboxRoot): remove duplicate words in root and open description #2399
Conversation
|
Thanks for the PR! Let's modify the description on |
📝 WalkthroughWalkthroughMinor documentation corrections in the Combobox component files. A duplicated preposition "with" in prop descriptions is removed, and a similar grammatical error in a JSDoc comment is corrected. No functional or behavioral changes. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
@zernonia done ! |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@docs/content/meta/ComboboxRoot.md`:
- Line 62: Two source components still contain the duplicated word "with" in
their description; open ListboxRoot.vue and ListboxFilter.vue and replace the
string "Can be binded with with" with the corrected "Can be binded with" (or the
desired final phrasing), so the source matches the auto-generated docs and the
change survives future codegen runs.
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
docs/content/meta/ComboboxRoot.mdpackages/core/src/Combobox/ComboboxRoot.vue
🔇 Additional comments (2)
docs/content/meta/ComboboxRoot.md (1)
80-80: LGTM!The duplicate "with" has been correctly removed, and this change aligns with the source file update in
ComboboxRoot.vueline 48.packages/core/src/Combobox/ComboboxRoot.vue (1)
48-48: LGTM!The duplicate "with" has been correctly removed from the JSDoc comment.
✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.
| { | ||
| 'name': 'modelValue', | ||
| 'description': '<p>The controlled value of the listbox. Can be binded with with <code>v-model</code>.</p>\n', | ||
| 'description': '<p>The controlled value of the listbox. Can be binded with <code>v-model</code>.</p>\n', |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
# Search for modelValue prop definition in Listbox source files
fd -e vue -e ts packages/core/src | head -20Repository: unovue/reka-ui
Length of output: 431
🏁 Script executed:
# Search more broadly for the modelValue property definition
rg -n "modelValue" packages/core/src/Listbox/ -A 2 -B 2 --type=vue --type=ts 2>/dev/null || rg -n "modelValue" packages/ -A 2 -B 2 --type=vue --type=ts 2>/dev/null | head -50Repository: unovue/reka-ui
Length of output: 40
🏁 Script executed:
# Look for the specific file mentioned and the typo "binded with with"
rg -n "binded with" . --type=vue --type=ts --type=md 2>/dev/null | head -30Repository: unovue/reka-ui
Length of output: 40
🏁 Script executed:
# Find the actual structure
ls -la packages/core/src/ 2>/dev/null | head -20Repository: unovue/reka-ui
Length of output: 1214
🏁 Script executed:
# Search for ComboboxRoot source files
fd . packages/core/src -name "*ComboboxRoot*" -o -name "*Listbox*" 2>/dev/null | head -20Repository: unovue/reka-ui
Length of output: 40
🏁 Script executed:
# Search for any JSDoc with "binded" text
rg "binded" packages/ docs/ --type-list 2>/dev/null | head -5Repository: unovue/reka-ui
Length of output: 40
🏁 Script executed:
# More direct search for the description text
rg "controlled value of the listbox" . --type=vue --type=ts -A 2 -B 2 2>/dev/nullRepository: unovue/reka-ui
Length of output: 40
🏁 Script executed:
# List Combobox source files
ls -la packages/core/src/Combobox/Repository: unovue/reka-ui
Length of output: 1563
🏁 Script executed:
# Search for the actual description text in Combobox files
cat packages/core/src/Combobox/ComboboxRoot.vue 2>/dev/null | grep -n "controlled value" -A 2 -B 2Repository: unovue/reka-ui
Length of output: 40
🏁 Script executed:
# Look for the description more broadly
find packages/core/src -name "*.vue" -o -name "*.ts" | xargs grep -l "modelValue" 2>/dev/null | grep -i comboboxRepository: unovue/reka-ui
Length of output: 462
🏁 Script executed:
# Check if there's a Listbox component mentioned
ls -la packages/core/src/ | grep -i listboxRepository: unovue/reka-ui
Length of output: 115
🏁 Script executed:
# Check the ComboboxRoot.vue for the modelValue prop description
cat packages/core/src/Combobox/ComboboxRoot.vue | head -150Repository: unovue/reka-ui
Length of output: 5212
🏁 Script executed:
# Check the Listbox directory
ls -la packages/core/src/Listbox/Repository: unovue/reka-ui
Length of output: 981
🏁 Script executed:
# Search for the description text and typo in both Combobox and Listbox
rg -n "binded with" packages/core/src/Combobox/ packages/core/src/Listbox/ 2>/dev/nullRepository: unovue/reka-ui
Length of output: 442
Fix the typo in the source files to prevent regression on codegen.
The auto-generated docs file has the corrected text, but the source files still contain the duplicate "with":
packages/core/src/Listbox/ListboxRoot.vueline 43: "Can be binded with with"packages/core/src/Listbox/ListboxFilter.vueline 10: "Can be binded with with"
Update both source files to remove the duplicate "with". Otherwise, this fix will be reverted the next time codegen runs.
🤖 Prompt for AI Agents
In `@docs/content/meta/ComboboxRoot.md` at line 62, Two source components still
contain the duplicated word "with" in their description; open ListboxRoot.vue
and ListboxFilter.vue and replace the string "Can be binded with with" with the
corrected "Can be binded with" (or the desired final phrasing), so the source
matches the auto-generated docs and the change survives future codegen runs.
2 participants
🔗 Linked issue
❓ Type of change
📚 Description
Resolves a typo in the combobox root and open descriptions
📸 Screenshots (if appropriate)
📝 Checklist
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.