fix: data-orientation in Resizable - #1939
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (33)
🚧 Files skipped from review as they are similar to previous changes (30)
📝 WalkthroughWalkthroughResizable handle and panel group selectors now use ChangesResizable orientation selectors
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This localized fix updates the Resizable attribute name across the affected component variants and generated outputs; no actionable merge-blocking risk remains beyond normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
deprecated/www/src/registry/default/ui/resizable/ResizablePanelGroup.vueParsing error: Unexpected token < deprecated/www/src/registry/new-york/ui/resizable/ResizablePanelGroup.vueParsing error: Unexpected token < deprecated/www/src/registry/registry-ui.tsParsing error: The keyword 'import' is reserved Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Change is correct — reka-ui renders One gap: this branch is based on a commit before LGTM after that. |
…irection Reka UI's SplitterGroup and SplitterResizeHandle expose the layout axis as `data-orientation="horizontal|vertical"` (alongside `data-panel-group`, `data-panel-group-id`). They have never rendered `data-panel-group-direction` — that attribute comes from React's react-resizable-panels and was carried over verbatim when the component was ported, so every `data-[panel-group-direction=vertical]:*` variant is dead CSS. SplitterGroup already sets `flex-direction` inline, so the group's variant was redundant either way and the visible breakage is entirely in the handle: in a vertical group it keeps its 1px-wide vertical geometry and an unrotated grip instead of becoming a horizontal divider. Retarget the variants at `data-orientation` in the reka base components and re-run the styles/registry build, which propagates to all eight per-style outputs (rhea included) and the published registry JSON. The legacy `default`/`new-york` registry JSON carried the same dead selector in ResizablePanelGroup and is fixed too; its ResizableHandle already used `data-orientation`, which is why only vertical groups looked broken there. Those two legacy files also pick up the trailing CRLF -> LF normalization that .gitattributes already mandates for apps/v4/public/r/**/*.json. `registry/new-york-v4` was already correct and is unchanged. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012KvDxDGp31TiTny8aXpoqv
f0df38f to
c315c07
Compare
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
c315c07 to
0b9ea77
Compare
Done, thanks for the quick review |
3 participants
🔗 Linked issue
#1938
❓ Type of change
📚 Description
fixed Resizable attribute
data-panel-group-direction --> data-orientation
📸 Screenshots (if appropriate)
📝 Checklist
Summary by CodeRabbit