Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add riscv64gc-unknown-linux-gnu target #30

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

JounQin
Copy link
Member

@JounQin JounQin commented Mar 21, 2025

No description provided.

@JounQin JounQin force-pushed the ci/testing branch 3 times, most recently from 621f131 to 9d245b5 Compare March 21, 2025 17:20
@JounQin
Copy link
Member Author

JounQin commented Mar 21, 2025

Hi! @Brooooooklyn

Sorry to bother you, I just followed a new created napi template's GitHub action workflow, but some targets don't compile successfully, any possible to help resolving?

Errors like

--- stderr
  CMake Error at /usr/local/share/cmake-3.31/Modules/CMakeTestCCompiler.cmake:67 (message):
    The C compiler

      "/usr/bin/clang"

    is not able to compile a simple test program.

    It fails with the following output:

      Change Dir: '/home/runner/work/rspack-resolver/rspack-resolver/target/s390x-unknown-linux-gnu/release/build/libmimalloc-sys2-57a6624d8e4f1f38/out/build/CMakeFiles/CMakeScratch/TryCompile-yRe3rg'
      
      Run Build Command(s): /usr/local/bin/cmake -E env VERBOSE=1 /usr/bin/gmake -f Makefile cmTC_c0cf6/fast
      /usr/bin/gmake  -f CMakeFiles/cmTC_c0cf6.dir/build.make CMakeFiles/cmTC_c0cf6.dir/build
      gmake[1]: Entering directory '/home/runner/work/rspack-resolver/rspack-resolver/target/s390x-unknown-linux-gnu/release/build/libmimalloc-sys2-57a6624d8e4f1f38/out/build/CMakeFiles/CMakeScratch/TryCompile-yRe3rg'
      Building C object CMakeFiles/cmTC_c0cf6.dir/testCCompiler.c.o
      /usr/bin/clang   -ffunction-sections -fdata-sections -fPIC --target=s390x-unknown-linux-gnu  -MD -MT CMakeFiles/cmTC_c0cf6.dir/testCCompiler.c.o -MF CMakeFiles/cmTC_c0cf6.dir/testCCompiler.c.o.d -o CMakeFiles/cmTC_c0cf6.dir/testCCompiler.c.o -c /home/runner/work/rspack-resolver/rspack-resolver/target/s390x-unknown-linux-gnu/release/build/libmimalloc-sys2-57a6624d8e4f1f38/out/build/CMakeFiles/CMakeScratch/TryCompile-yRe3rg/testCCompiler.c
      Linking C executable cmTC_c0cf6
      /usr/local/bin/cmake -E cmake_link_script CMakeFiles/cmTC_c0cf6.dir/link.txt --verbose=1
      /usr/bin/ld: unrecognised emulation mode: elf64_s390
      Supported emulations: elf_x86_64 elf32_x86_64 elf_i386 elf_iamcu i386pep i386pe
      clang: error: linker command failed with exit code 1 (use -v to see invocation)
      /usr/bin/clang  -ffunction-sections -fdata-sections -fPIC --target=s390x-unknown-linux-gnu  CMakeFiles/cmTC_c0cf6.dir/testCCompiler.c.o -o cmTC_c0cf6
      gmake[1]: *** [CMakeFiles/cmTC_c0cf6.dir/build.make:103: cmTC_c0cf6] Error 1
      gmake[1]: Leaving directory '/home/runner/work/rspack-resolver/rspack-resolver/target/s390x-unknown-linux-gnu/release/build/libmimalloc-sys2-57a6624d8e4f1f38/out/build/CMakeFiles/CMakeScratch/TryCompile-yRe3rg'
      gmake: *** [Makefile:134: cmTC_c0cf6/fast] Error 2

cc @eaibmz @SukkaW

Are you familiar with this part?

@JounQin JounQin changed the title ci: test new nap build workflow ci: test new napi build workflow Mar 22, 2025
@JounQin JounQin force-pushed the ci/testing branch 20 times, most recently from 2013b5a to 45e4c37 Compare March 22, 2025 12:14
@Brooooooklyn
Copy link
Contributor

https://github.com/oxc-project/oxc-node/blob/main/.github/workflows/CI.yml#L119-L129

@JounQin JounQin force-pushed the ci/testing branch 3 times, most recently from 14e1e02 to ad65e6d Compare March 26, 2025 01:16
@JounQin JounQin force-pushed the ci/testing branch 2 times, most recently from e06f086 to 151e42a Compare March 26, 2025 01:45
@JounQin
Copy link
Member Author

JounQin commented Mar 26, 2025

oxc-project/oxc-node@main/.github/workflows/CI.yml#L119-L129

@Brooooooklyn Thanks! I followed oxc-node repository changes, and s390x-unknown-linux-gnu is passing now, but oxc-node does not support riscv64gc-unknown-linux-gnu, I tried export CFLAGS="-fuse-ld=lld" && pnpm build --use-napi-cross --target but it doesn't work, any suggestion?

@JounQin JounQin force-pushed the main branch 15 times, most recently from 7c74ca1 to 5cd9ced Compare March 26, 2025 02:18
@JounQin JounQin force-pushed the ci/testing branch 2 times, most recently from 82b50cf to 6bef961 Compare March 26, 2025 02:53
@JounQin JounQin changed the title ci: test new napi build workflow feat: add riscv64gc-unknown-linux-gnu target Mar 26, 2025
@JounQin JounQin force-pushed the ci/testing branch 2 times, most recently from 53184c8 to 01b24dd Compare March 26, 2025 04:50
@JounQin JounQin force-pushed the ci/testing branch 3 times, most recently from 7dacaf6 to f560021 Compare March 26, 2025 04:55
Copy link

sonarqubecloud bot commented Apr 1, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants