Skip to content

Indicating encoding explicitly in logging_utils.py #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Hmzbo
Copy link

@Hmzbo Hmzbo commented Apr 9, 2025

As I detailed in the issue number #109
without indicating explicitly the encoding when reading the Trainer files from the trl library, a UnicodeDecodeError could arise if the the locale preferred encoding is not set to utf-8.
I have tested the GRPO Trainer after with this minor change and it worked as intended.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant