Fix LoRA hot swapping #116
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LoRA hot swapping is broken as documented in unslothai/unsloth#2322
This is due to an overly permissive regex which when loading multiple adapters which will apply the first adapter correctly but when applying the second adapter it will target layers in the first adapter
The main change is a tighter regex in
get_peft_regex
This also formats some of the code to be more up to spec with ruff linting.
I tested this with qwen-vl-2.5 3b and everything appears to work