Skip to content

fix: video fps accumulation bug in _collate_prompt_completion #413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yurekami wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: video fps accumulation bug in _collate_prompt_completion #413

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions unsloth_zoo/vision_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1123,6 +1123,7 @@ def _pad_to_multiple(self, input_ids, attention_mask, completion_mask, side, pad

def _collate_prompt_completion(self, examples):
prompt_texts, completion_texts, images, videos = [], [], [], []
video_kwargs = {'fps': []}

for ex in examples:
p, c = ex["prompt"], ex["completion"]
Expand Down Expand Up @@ -1164,9 +1165,8 @@ def _collate_prompt_completion(self, examples):

if vids and len(vids) > 0: # Works for list, tuple or tensor
videos.append(vids)
if vids_kwarg is None:
vids_kwarg = {"fps": []}
vids_kwarg['fps'].extend(vids_kwarg['fps'])
if vids_kwarg is not None and 'fps' in vids_kwarg:
video_kwargs['fps'].extend(vids_kwarg['fps'])

prompt_kwargs = dict(
padding=True,
Expand All @@ -1184,8 +1184,8 @@ def _collate_prompt_completion(self, examples):
prompt_kwargs["images"] = images
if len(videos) > 0:
prompt_kwargs["videos"] = videos
vids_kwarg["fps"] = collapse_fps(vids_kwarg['fps'])
for k, v in vids_kwarg.items():
video_kwargs["fps"] = collapse_fps(video_kwargs['fps'])
for k, v in video_kwargs.items():
prompt_kwargs[k] = v

proc_prompts = self.processor(text=prompt_texts, **prompt_kwargs)
Expand Down