Conversation
Summary of ChangesHello @Datta0, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a targeted performance optimization for vLLM when running FP8 quantized models on NVIDIA Hopper GPUs. By explicitly disabling DeepGemm and defaulting to Triton for FP8 operations under these specific conditions, the change aims to mitigate observed performance regressions and improve throughput, as evidenced by recent benchmarks. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a targeted performance optimization for FP8 models running on NVIDIA's Blackwell architecture. By detecting the GPU's compute capability, it disables vLLM's DeepGEMM in favor of Triton, which has been observed to be faster. The change is well-justified and includes helpful comments. I have one minor suggestion to make the code even more self-documenting by clarifying the magic number used for the architecture check.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 02daf42eca
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| is_fp8 = "fp8" in model_name.lower() or (quant_method in ("fp8", "fbgemm_fp8")) | ||
|
|
||
| if is_fp8: | ||
| major_version, minor_version = torch.cuda.get_device_capability() |
There was a problem hiding this comment.
Guard FP8 deepgemm toggle behind CUDA checks
load_vllm has explicit non-CUDA paths (including XPU), but this new FP8 branch unconditionally calls torch.cuda.get_device_capability(). On Intel/XPU environments, loading an FP8 model now fails immediately with a CUDA runtime error before vLLM initialization, which is a regression for that code path. Please gate this capability query on DEVICE_TYPE == "cuda" (or use the existing device abstraction) before touching CUDA APIs.
Useful? React with 👍 / 👎.
It is noticed that deepgemm is slower (for at least B200) on vLLM
https://x.com/TheZachMueller/status/2024619480580510117?s=20
I was able to see a 10% speed difference in
vllm bench throughputcommand on 1xB200. Note that there maybe other factors at play. This is just beting set for FP8 and B200 so this should be safe