Open
Conversation
23tae
reviewed
Sep 11, 2024
| val identityList = identityRepository.findByUserId(userId); | ||
|
|
||
| // 신분의 개수가 1개인 경우 업데이트 로직을 실행하지 않습니다. | ||
| if (identityList?.size == 1) return null; |
Member
There was a problem hiding this comment.
신분이 하나인 경우 예외를 던지는 것도 하나의 방법이 될 것 같습니다.
Comment on lines
+31
to
+33
| identityList?.forEach { identity: Identity -> | ||
| identityRepository.updateActiveIdentityList(identity.id, userId) | ||
| } |
Member
There was a problem hiding this comment.
IdentityRepository 내부에 대표 신분을 설정하는 함수를 정의해서 비즈니스 로직과 분리하면 좋을 것 같습니다.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔍️ 이 PR을 통해 해결하려는 문제가 무엇인가요?
✨ 이 PR에서 핵심적으로 변경된 사항은 무엇일까요?
🔖 핵심 변경 사항 외에 추가적으로 변경된 부분이 있나요?
🙏 Reviewer 분들이 이런 부분을 신경써서 봐 주시면 좋겠어요
🩺 이 PR에서 테스트 혹은 검증이 필요한 부분이 있을까요?
📌 PR 진행 시 이러한 점들을 참고해 주세요
📝 Assignee를 위한 CheckList