UOSLIFE-Assignment-FE-1 #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chaehee03
commented
Jul 2, 2023
Chaehee03
commented
- Text 컴포넌트, Cafteria 컴포넌트 작성.
- 스토리북 작성.
ContributorsCommit-Lint commandsYou can trigger Commit-Lint actions by commenting on this PR:
|
ratafa
approved these changes
Jul 4, 2023
| @@ -0,0 +1,58 @@ | |||
| import styled from "styled-components"; | |||
|
|
|||
| export const TabContainer = styled("div")` | |||
|
|
||
| export default Text; | ||
| const StyledText = styled.div<TextProps>` | ||
| font-size: ${(props) => props.fontSize}px; |
There was a problem hiding this comment.
객체 비구조화 할당을 사용하여
font-size: ${({fontSize}) => fontSize}px 로도 사용 가능합니다
| } from "./Cafeteria.style"; | ||
|
|
||
| export default Cafeteria; | ||
| export const Cafeteria = ({ cafeteria }: any) => { |
| color="#656D78" | ||
| /> | ||
| </InfoTime> | ||
| </InfoContent1> |
There was a problem hiding this comment.
변수명을 다른 개발자들도 알아볼 수 있도록 잘 지어주세요!
InfoContent1, InfoContent2 이렇게 숫자로 변수의 속성을 나타내는 것 보다는 InfoContent 라는 하나의 공통된 변수로 표현해주는게 더욱 용이하다고 생각합니다
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.