Planar transformer#162
Merged
Merged
Conversation
added 20 commits
July 21, 2025 15:43
merge the main into planar_transformer branch
merge the main into branch
…tion layers for rectangular windings. It is not fully implemented, just for Foilhorizontal scheme.
…alternating for vertical placemment strategy.
merge the main into branch
Megre the main into branch
gituser789
requested changes
Aug 27, 2025
Contributor
gituser789
left a comment
There was a problem hiding this comment.
Nice! See the comments.
all three planar transformers examples should be added to tests/integration/basic_examples_test.py
it is necessary to have an integration test which tests the result files against fixtures.
one test should be placed into tests/integration/compare_results_part_1_test.py
in case of you provide more tests, they should go into ..._part_2_test.py
gituser789
approved these changes
Aug 28, 2025
tillpiepenbrock
requested changes
Aug 28, 2025
| geo.single_simulation(freq=1000000, current=[3, 5], phi_deg=[0, 180], show_fem_simulation_results=show_visual_outputs) | ||
|
|
||
| example_thermal_simulation(show_visual_outputs, flag_insulation=True) | ||
|
|
Contributor
| insulation.add_winding_insulations([[1.15e-4, 1.15e-4], | ||
| [1.15e-4, 1.15e-4]]) | ||
| insulation.add_insulation_between_layers(thickness=0.01e-3) | ||
| geo.set_insulation(insulation) |
Contributor
Contributor
Author
There was a problem hiding this comment.
It needs time for Implantation. it could be in the next PR
gituser789
approved these changes
Sep 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


-New schemes for planar transformer
-Time domain mode- visualization is also added